Attachment 361523 Details for Bug 194445 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

debug-setting-1.patch (text/plain), 3.81 KB, created by Joseph Pecoraro on 2019-02-08 12:23:10 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-02-08 12:23:10 PST

Size: 3.81 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 07884292f67..09d1db43699 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-02-08  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Add Debug setting to show Internal Object Classes in Heap Snapshot
>+        https://bugs.webkit.org/show_bug.cgi?id=194445
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Base/Setting.js:
>+        * UserInterface/Views/HeapSnapshotDataGridTree.js:
>+        (WI.HeapSnapshotInstancesDataGridTree.prototype.populateTopLevel):
>+        * UserInterface/Views/SettingsTabContentView.js:
>+        (WI.SettingsTabContentView.prototype._createDebugSettingsView):
>+
> 2019-02-07  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: Make Timeline markers light gray instead of black in dark mode
>diff --git a/Source/WebInspectorUI/UserInterface/Base/Setting.js b/Source/WebInspectorUI/UserInterface/Base/Setting.js
>index d0831074548..105f124489b 100644
>--- a/Source/WebInspectorUI/UserInterface/Base/Setting.js
>+++ b/Source/WebInspectorUI/UserInterface/Base/Setting.js
>@@ -167,4 +167,5 @@ WI.settings = {
>     filterMultiplexingBackendInspectorProtocolMessages: new WI.Setting("filter-multiplexing-backend-inspector-protocol-messages", true),
>     layoutDirection: new WI.Setting("layout-direction-override", "system"),
>     pauseForInternalScripts: new WI.Setting("pause-for-internal-scripts", false),
>+    debugShowInternalObjectsInHeapSnapshot: new WI.Setting("debug-show-internal-objects-in-heap-snapshot", false),
> };
>diff --git a/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotDataGridTree.js b/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotDataGridTree.js
>index a488b548ff6..d1425141976 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotDataGridTree.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotDataGridTree.js
>@@ -215,9 +215,12 @@ WI.HeapSnapshotInstancesDataGridTree = class HeapSnapshotInstancesDataGridTree e
> 
>     populateTopLevel()
>     {
>-        // Populate the first level with the different non-internal classes.
>+        // Populate the first level with the different classes.
>+        let skipInternalOnlyObjects = !WI.settings.debugShowInternalObjectsInHeapSnapshot.value;
>+
>         for (let [className, {size, retainedSize, count, internalCount, deadCount}] of this.heapSnapshot.categories) {
>-            if (count === internalCount)
>+            // Possibly skip internal only classes.
>+            if (skipInternalOnlyObjects && count === internalCount)
>                 continue;
> 
>             // FIXME: <https://webkit.org/b/157905> Web Inspector: Provide a way to toggle between showing only live objects and live+dead objects
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>index 7e5e012c7c8..7ddf01242f7 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>@@ -324,6 +324,10 @@ WI.SettingsTabContentView = class SettingsTabContentView extends WI.TabContentVi
> 
>         this._debugSettingsView.addSeparator();
> 
>+        this._debugSettingsView.addSetting(WI.unlocalizedString("Heap Snapshot:"), WI.settings.debugShowInternalObjectsInHeapSnapshot, WI.unlocalizedString("Show Internal Objects"));
>+
>+        this._debugSettingsView.addSeparator();
>+
>         this._debugSettingsView.addSetting(WI.unlocalizedString("Debugging:"), WI.settings.pauseForInternalScripts, WI.unlocalizedString("Pause in WebKit-internal scripts"));
> 
>         this._debugSettingsView.addSetting(WI.unlocalizedString("Uncaught Exception Reporter:"), WI.settings.enableUncaughtExceptionReporter, WI.unlocalizedString("Enabled"));

Actions: View | Formatted Diff | Diff

Attachments on bug 194445: 361523 | 361541