Attachment 361520 Details for Bug 194443 – Patch

[patch] Patch

bug-194443-20190208114943.patch (text/plain), 1.76 KB, created by Justin Fan on 2019-02-08 11:49:43 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Justin Fan

Created: 2019-02-08 11:49:43 PST

Size: 1.76 KB

patch

obsolete

>Subversion Revision: 241201
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index b7b3ff3623837c2e4189270c8238ff76ce82707b..7b7119956874ef863d20d9da03e4aea37000dd80 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-02-08  Justin Fan  <justin_fan@apple.com>
>+
>+        [Web GPU] Build fix for MTLStorageMode availability on different Cocoa platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=194443
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        For MTLTextures, MTLStorageModeManaged is only available on macOS. Other platforms,
>+        if not using MTLStorageModePrivate, must use MTLStorageModeShared.
>+
>+        Behavior unchanged.
>+
>+        * platform/graphics/gpu/cocoa/GPUTextureMetal.mm:
>+        (WebCore::storageModeForPixelFormatAndSampleCount): 
>+
> 2019-02-08  Youenn Fablet  <youenn@apple.com>
> 
>         Running RTCRtpSender.getCapabilities("video") before initial offer breaks VP8
>diff --git a/Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm b/Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm
>index d77f3f1cc94141b70e4cf21d4bd7478c96f3628c..b793e025e5b3bae4fa714f4893004256613315a2 100644
>--- a/Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm
>+++ b/Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm
>@@ -81,7 +81,11 @@ static MTLStorageMode storageModeForPixelFormatAndSampleCount(MTLPixelFormat for
>     if (format == MTLPixelFormatDepth32Float_Stencil8 || samples > 1)
>         return MTLStorageModePrivate;
> 
>+#if PLATFORM(MAC)
>     return MTLStorageModeManaged;
>+#else
>+    return MTLStorageModeShared;
>+#endif
> }
> 
> static RetainPtr<MTLTextureDescriptor> tryCreateMtlTextureDescriptor(const char* const functionName, const GPUTextureDescriptor&& descriptor)

Actions: View | Formatted Diff | Diff

Attachments on bug 194443: 361520