WebKit Bugzilla
Attachment 361506 Details for
Bug 194418
: webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194418-20190208084725.patch (text/plain), 3.60 KB, created by
Jonathan Bedard
on 2019-02-08 08:47:26 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Jonathan Bedard
Created:
2019-02-08 08:47:26 PST
Size:
3.60 KB
patch
obsolete
>Index: Tools/ChangeLog >=================================================================== >--- Tools/ChangeLog (revision 241195) >+++ Tools/ChangeLog (working copy) >@@ -1,3 +1,22 @@ >+2019-02-08 Jonathan Bedard <jbedard@apple.com> >+ >+ webkitpy: CrashLogs.find_all_logs may return a string or a dictionary >+ https://bugs.webkit.org/show_bug.cgi?id=194418 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Do not include errors trying when trying to find crashlogs at the end of >+ a run-webkit-tests run since those errors change the output of >+ CrashLogs.find_all_logs from an empty dictionary to a string, which may >+ break code attempting to parse crash log results. >+ >+ * Scripts/webkitpy/port/darwin.py: >+ (DarwinPort._look_for_all_crash_logs_in_log_dir): >+ * Scripts/webkitpy/port/ios_device.py: >+ (IOSDevicePort._look_for_all_crash_logs_in_log_dir): >+ * Scripts/webkitpy/port/watch_device.py: >+ (WatchDevicePort._look_for_all_crash_logs_in_log_dir): >+ > 2019-02-08 Benjamin Poulain <benjamin@webkit.org> > > clampTo(): do not convert the input to double when dealing with integers >Index: Tools/Scripts/webkitpy/port/darwin.py >=================================================================== >--- Tools/Scripts/webkitpy/port/darwin.py (revision 241144) >+++ Tools/Scripts/webkitpy/port/darwin.py (working copy) >@@ -113,7 +113,7 @@ class DarwinPort(ApplePort): > > def _look_for_all_crash_logs_in_log_dir(self, newer_than): > crash_log = CrashLogs(self.host, self.path_to_crash_logs(), crash_logs_to_skip=self._crash_logs_to_skip_for_host.get(self.host, [])) >- return crash_log.find_all_logs(include_errors=True, newer_than=newer_than) >+ return crash_log.find_all_logs(newer_than=newer_than) > > def _get_crash_log(self, name, pid, stdout, stderr, newer_than, time_fn=None, sleep_fn=None, wait_for_log=True, target_host=None): > # Note that we do slow-spin here and wait, since it appears the time >Index: Tools/Scripts/webkitpy/port/ios_device.py >=================================================================== >--- Tools/Scripts/webkitpy/port/ios_device.py (revision 241144) >+++ Tools/Scripts/webkitpy/port/ios_device.py (working copy) >@@ -67,7 +67,7 @@ class IOSDevicePort(IOSPort): > log_list = {} > for device in self.devices(): > crash_log = CrashLogs(device, self.path_to_crash_logs(), crash_logs_to_skip=self._crash_logs_to_skip_for_host.get(device, [])) >- log_list.update(crash_log.find_all_logs(include_errors=True, newer_than=newer_than)) >+ log_list.update(crash_log.find_all_logs(newer_than=newer_than)) > return log_list > > def _get_crash_log(self, name, pid, stdout, stderr, newer_than, time_fn=None, sleep_fn=None, wait_for_log=True, target_host=None): >Index: Tools/Scripts/webkitpy/port/watch_device.py >=================================================================== >--- Tools/Scripts/webkitpy/port/watch_device.py (revision 241144) >+++ Tools/Scripts/webkitpy/port/watch_device.py (working copy) >@@ -65,7 +65,7 @@ class WatchDevicePort(WatchPort): > log_list = {} > for device in self.devices(): > crash_log = CrashLogs(device, self.path_to_crash_logs(), crash_logs_to_skip=self._crash_logs_to_skip_for_host.get(device, [])) >- log_list.update(crash_log.find_all_logs(include_errors=True, newer_than=newer_than)) >+ log_list.update(crash_log.find_all_logs(newer_than=newer_than)) > return log_list > > def _get_crash_log(self, name, pid, stdout, stderr, newer_than, time_fn=None, sleep_fn=None, wait_for_log=True, target_host=None):
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194418
:
361506
|
361518