Attachment 361505 Details for Bug 194414 – Patch

[patch] Patch

bug-194414-20190208172731.patch (text/plain), 2.48 KB, created by Alicia Boya García on 2019-02-08 08:27:33 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alicia Boya García

Created: 2019-02-08 08:27:33 PST

Size: 2.48 KB

patch

obsolete

>Subversion Revision: 240793
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1ae663966c8654338f313cc099aef4e4ca6ae184..75de8243ae67f08a08197cbab3839af139ca0976 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,25 @@
>+2019-02-08  Alicia Boya GarcÃa  <aboya@igalia.com>
>+
>+        [MSE][GStreamer] Add missing return type to lambda
>+        https://bugs.webkit.org/show_bug.cgi?id=194414
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Since g_signal_connect() is untyped, a compiler error was not
>+        generated when a lambda with a missing GstFlowReturn return type was
>+        provided for a signal that expects it.
>+
>+        This used to work before r240784 because a recent function call had
>+        set GST_FLOW_OK in the return value register and it happened to
>+        survive until the lambda function call ended. Starting on that commit
>+        such return value was removed and it stopped working on debug.
>+
>+        Of course, the actual problem is in the signature of the lambda
>+        function, and this patch fixes that.
>+
>+        * platform/graphics/gstreamer/mse/AppendPipeline.cpp:
>+        (WebCore::AppendPipeline::AppendPipeline):
>+
> 2019-01-31  Alicia Boya GarcÃa  <aboya@igalia.com>
> 
>         [MSE][GStreamer] Unreviewed debug build fix, obsolete assert
>diff --git a/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp b/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
>index 5067cf3272fa3afda30c2fd403fd980062d7b88e..2d9323811ff3ee96c40befb8e87bab04e014a42b 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
>@@ -204,8 +204,9 @@ AppendPipeline::AppendPipeline(Ref<MediaSourceClientGStreamerMSE> mediaSourceCli
>             appendPipeline->didReceiveInitializationSegment();
>         });
>     }), this);
>-    g_signal_connect(m_appsink.get(), "new-sample", G_CALLBACK(+[](GstElement* appsink, AppendPipeline* appendPipeline) {
>+    g_signal_connect(m_appsink.get(), "new-sample", G_CALLBACK(+[](GstElement* appsink, AppendPipeline* appendPipeline) -> GstFlowReturn {
>         appendPipeline->handleAppsinkNewSampleFromStreamingThread(appsink);
>+        return GST_FLOW_OK;
>     }), this);
>     g_signal_connect(m_appsink.get(), "eos", G_CALLBACK(+[](GstElement*, AppendPipeline* appendPipeline) {
>         // basesrc will emit an EOS after it has received a GST_FLOW_ERROR. That's the only case we are expecting.

Actions: View | Formatted Diff | Diff

Attachments on bug 194414: 361505