Attachment 361498 Details for Bug 193981 – patch

[patch] patch

c-backup.diff (text/plain), 2.97 KB, created by Saam Barati on 2019-02-08 01:14:38 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2019-02-08 01:14:38 PST

Size: 2.97 KB

patch

obsolete

>Index: PerformanceTests/ChangeLog
>===================================================================
>--- PerformanceTests/ChangeLog	(revision 241191)
>+++ PerformanceTests/ChangeLog	(working copy)
>@@ -1,3 +1,18 @@
>+2019-02-08  Saam barati  <sbarati@apple.com>
>+
>+        Update JetStream2 CLI to not print "ms" since we now just print the score values
>+        https://bugs.webkit.org/show_bug.cgi?id=193981
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * JetStream2/JetStreamDriver.js:
>+        (DefaultBenchmark.prototype.updateUIAfterRun):
>+        (DefaultBenchmark):
>+        (WSLBenchmark.prototype.updateUIAfterRun):
>+        (WSLBenchmark):
>+        (WasmBenchmark.prototype.updateUIAfterRun):
>+        (WasmBenchmark):
>+
> 2019-01-31  Sihui Liu  <sihui_liu@apple.com>
> 
>         REGRESSION (r240358): IndexedDB/large-binary-keys.html and IndexedDB/large-string-keys.html perf tests failing
>Index: PerformanceTests/JetStream2/JetStreamDriver.js
>===================================================================
>--- PerformanceTests/JetStream2/JetStreamDriver.js	(revision 241191)
>+++ PerformanceTests/JetStream2/JetStreamDriver.js	(working copy)
>@@ -633,9 +633,9 @@ class DefaultBenchmark extends Benchmark
>             return;
>         }
> 
>-        print("    Startup:", uiFriendlyNumber(this.firstIteration), "ms");
>-        print("    Worst Case:", uiFriendlyNumber(this.worst4), "ms");
>-        print("    Average:", uiFriendlyNumber(this.average), "ms");
>+        print("    Startup:", uiFriendlyNumber(this.firstIteration));
>+        print("    Worst Case:", uiFriendlyNumber(this.worst4));
>+        print("    Average:", uiFriendlyNumber(this.average));
>         print("    Score:", uiFriendlyNumber(this.score));
>         if (RAMification) {
>             print("    Current Footprint:", uiFriendlyNumber(this.currentFootprint));
>@@ -727,8 +727,8 @@ class WSLBenchmark extends Benchmark {
>             return;
>         }
> 
>-        print("    Stdlib:", uiFriendlyNumber(this.stdlib), "ms");
>-        print("    Tests:", uiFriendlyNumber(this.mainRun), "ms");
>+        print("    Stdlib:", uiFriendlyNumber(this.stdlib));
>+        print("    Tests:", uiFriendlyNumber(this.mainRun));
>         print("    Score:", uiFriendlyNumber(this.score));
>         if (RAMification) {
>             print("    Current Footprint:", uiFriendlyNumber(this.currentFootprint));
>@@ -883,8 +883,8 @@ class WasmBenchmark extends Benchmark {
>             document.getElementById(this.scoreID).innerHTML = uiFriendlyNumber(this.score);
>             return;
>         }
>-        print("    Startup:", uiFriendlyNumber(this.startupTime), "ms");
>-        print("    Run time:", uiFriendlyNumber(this.runTime), "ms");
>+        print("    Startup:", uiFriendlyNumber(this.startupTime));
>+        print("    Run time:", uiFriendlyNumber(this.runTime));
>         if (RAMification) {
>             print("    Current Footprint:", uiFriendlyNumber(this.currentFootprint));
>             print("    Peak Footprint:", uiFriendlyNumber(this.peakFootprint));

Actions: View | Formatted Diff | Diff

Attachments on bug 193981: 361498