Attachment 361465 Details for Bug 194417 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

light-1.patch (text/plain), 1.99 KB, created by Joseph Pecoraro on 2019-02-07 16:12:13 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-02-07 16:12:13 PST

Size: 1.99 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 278ff91da89..07884292f67 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-02-07  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Make Timeline markers light gray instead of black in dark mode
>+        https://bugs.webkit.org/show_bug.cgi?id=194417
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/RenderingFrameTimelineOverviewGraph.css:
>+        (.timeline-overview-graph.rendering-frame > .divider):
>+        * UserInterface/Views/TimelineRuler.css:
>+        (.timeline-ruler > .markers > .divider):
>+
> 2019-02-06  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: DOM: don't send the entire function string with each event listener
>diff --git a/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.css b/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.css
>index 0f609387ab4..f1c16047ada 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.css
>@@ -34,7 +34,7 @@
>     width: 100%;
>     height: 1px;
> 
>-    background-color: hsla(0, 0%, 0%, 0.07);
>+    background-color: hsla(0, 0%, var(--foreground-lightness), 0.07);
>     text-align: right;
> 
>     pointer-events: none;
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css b/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css
>index 78f75168e37..9f066628f52 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css
>@@ -110,7 +110,7 @@ body[dir=rtl] .timeline-ruler > .header > .divider > .label {
>     width: 1px;
>     top: 1px;
>     bottom: 0;
>-    background-color: hsla(0, 0%, 0%, 0.05);
>+    background-color: hsla(0, 0%, var(--foreground-lightness), 0.07);
> }
> 
> .timeline-ruler > .markers > .marker {

Actions: View | Formatted Diff | Diff

Attachments on bug 194417: 361463 | 361464 | 361465