Attachment 361446 Details for Bug 194416 – Patch

[patch] Patch

bug-194416-20190207142855.patch (text/plain), 1.27 KB, created by Jonathan Bedard on 2019-02-07 14:28:55 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2019-02-07 14:28:55 PST

Size: 1.27 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 241144)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2019-02-07  Jonathan Bedard  <jbedard@apple.com>
>+
>+        webkitpy: Respect --dedicated-simulators flag
>+        https://bugs.webkit.org/show_bug.cgi?id=194416
>+        <rdar://problem/47894722>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitpy/port/device_port.py:
>+        (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
>+        available devices can be safely ignored.
>+
> 2019-02-07  Keith Rollin  <krollin@apple.com>
> 
>         Remove extra copy of 100x100-red.tga
>Index: Tools/Scripts/webkitpy/port/device_port.py
>===================================================================
>--- Tools/Scripts/webkitpy/port/device_port.py	(revision 241144)
>+++ Tools/Scripts/webkitpy/port/device_port.py	(working copy)
>@@ -143,7 +143,7 @@ class DevicePort(DarwinPort):
>                 continue
>             if device.device_type in self.DEVICE_TYPE:
>                 types.add(device.device_type)
>-        if types:
>+        if types and not self.get_option('dedicated_simulators', False):
> 
>             def sorted_by_default_device_type(type):
>                 try:

Actions: View | Formatted Diff | Diff

Attachments on bug 194416: 361446