WebKit Bugzilla
Attachment 361429 Details for
Bug 194408
: Web Inspector: Fix modify-css-property-race.html flakiness
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
patch.txt (text/plain), 1.93 KB, created by
Nikita Vasilyev
on 2019-02-07 12:43:37 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Nikita Vasilyev
Created:
2019-02-07 12:43:37 PST
Size:
1.93 KB
patch
obsolete
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index d0fda69a92f..14853b645c7 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,14 @@ >+2019-02-07 Nikita Vasilyev <nvasilyev@apple.com> >+ >+ Web Inspector: Fix modify-css-property-race.html flakiness >+ https://bugs.webkit.org/show_bug.cgi?id=194408 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Event listener wasn't removed property, sometimes causing it to fire one more time. >+ >+ * inspector/css/modify-css-property-race.html: >+ > 2019-02-06 Andy Estes <aestes@apple.com> > > [Payment Request] It should be possible to require a phonetic name for shipping contacts >diff --git a/LayoutTests/inspector/css/modify-css-property-race.html b/LayoutTests/inspector/css/modify-css-property-race.html >index d899b6349b1..68dc61ff709 100644 >--- a/LayoutTests/inspector/css/modify-css-property-race.html >+++ b/LayoutTests/inspector/css/modify-css-property-race.html >@@ -61,6 +61,7 @@ function test() { > > InspectorTest.evaluateInPage("expand()"); > let updateCount = 0; >+ let style = getInlineStyleDeclaration(); > > function styleDecorationUpdated() { > ++updateCount; >@@ -77,12 +78,11 @@ function test() { > InspectorTest.expectGreaterThanOrEqual(heightNumber, 101, "Height should be 101px or more."); > > InspectorTest.evaluateInPage("stopExpanding()"); >- WI.CSSStyleDeclaration.removeEventListener(WI.CSSStyleDeclaration.Event.PropertiesChanged, styleDecorationUpdated); >+ style.removeEventListener(WI.CSSStyleDeclaration.Event.PropertiesChanged, styleDecorationUpdated); > resolve(); > } > } > >- let style = getInlineStyleDeclaration(); > style.addEventListener(WI.CSSStyleDeclaration.Event.PropertiesChanged, styleDecorationUpdated); > } > });
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194408
: 361429