Attachment 361419 Details for Bug 194364 – Patch

[patch] Patch

bug-194364-20190207105902.patch (text/plain), 2.86 KB, created by Alex Christensen on 2019-02-07 10:59:02 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2019-02-07 10:59:02 PST

Size: 2.86 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 241127)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,20 @@
>+2019-02-07  Alex Christensen  <achristensen@webkit.org>
>+
>+        Print backgrounds preference should be honored instead of WKWebViewConfiguration value
>+        https://bugs.webkit.org/show_bug.cgi?id=194364
>+        <rdar://problem/47627599>
>+
>+        Reviewed by Tim Horton.
>+
>+        Without this patch, changing the preference for printing the background has no effect.
>+        This patch fixes that, and I verified it manually by checking "Print backgrounds" in Safari's print menu.
>+        Unfortunately, the only way to test this is actually printing because only values from WebPageProxy::preferences
>+        or WebPageProxy::configuration's preferences are exposed to the API, but values from WebPageProxy::preferencesStore
>+        are used when printing.  Actually printing verifies this change fixes the bug.
>+
>+        * UIProcess/API/Cocoa/WKWebView.mm:
>+        (-[WKWebView _initializeWithConfiguration:]):
>+
> 2019-02-07  Alex Christensen  <achristensen@webkit.org>
> 
>         Deprecate WKBundlePageSetDefersLoading
>Index: Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>===================================================================
>--- Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	(revision 241028)
>+++ Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	(working copy)
>@@ -588,7 +588,10 @@ - (void)_initializeWithConfiguration:(WK
>     pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::suppressesIncrementalRenderingKey(), WebKit::WebPreferencesStore::Value(!![_configuration suppressesIncrementalRendering]));
> 
>     pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::shouldRespectImageOrientationKey(), WebKit::WebPreferencesStore::Value(!![_configuration _respectsImageOrientation]));
>+#if !PLATFORM(MAC)
>+    // FIXME: Expose WKPreferences._shouldPrintBackgrounds on iOS, adopt it in all iOS clients, and remove this and WKWebViewConfiguration._printsBackgrounds.
>     pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::shouldPrintBackgroundsKey(), WebKit::WebPreferencesStore::Value(!![_configuration _printsBackgrounds]));
>+#endif
>     pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::incrementalRenderingSuppressionTimeoutKey(), WebKit::WebPreferencesStore::Value([_configuration _incrementalRenderingSuppressionTimeout]));
>     pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::javaScriptMarkupEnabledKey(), WebKit::WebPreferencesStore::Value(!![_configuration _allowsJavaScriptMarkup]));
>     pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::shouldConvertPositionStyleOnCopyKey(), WebKit::WebPreferencesStore::Value(!![_configuration _convertsPositionStyleOnCopy]));

Actions: View | Formatted Diff | Diff

Attachments on bug 194364: 361408 | 361419