Attachment 361394 Details for Bug 194391 – Patch

[patch] Patch

Patch.txt (text/plain), 5.13 KB, created by zalan on 2019-02-07 08:05:06 PST

(hide)

Description:

Filename:

MIME Type:

Creator: zalan

Created: 2019-02-07 08:05:06 PST

Size: 5.13 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index d8a3974fa6e..5499a5b99c5 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-02-07  Zalan Bujtas  <zalan@apple.com>
>+
>+        [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
>+        https://bugs.webkit.org/show_bug.cgi?id=194391
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * fast/block/block-only/absolute-positioned-min-max-percentage-with-parent-padding-expected.html: Added.
>+        * fast/block/block-only/absolute-positioned-min-max-percentage-with-parent-padding.html: Added.
>+
> 2019-02-06  Justin Fan  <justin_fan@apple.com>
> 
>         [Web GPU] Implement supporting dictionaries for GPUTexture
>diff --git a/LayoutTests/fast/block/block-only/absolute-positioned-min-max-percentage-with-parent-padding-expected.html b/LayoutTests/fast/block/block-only/absolute-positioned-min-max-percentage-with-parent-padding-expected.html
>new file mode 100644
>index 00000000000..dd4f685c175
>--- /dev/null
>+++ b/LayoutTests/fast/block/block-only/absolute-positioned-min-max-percentage-with-parent-padding-expected.html
>@@ -0,0 +1,17 @@
>+<style>
>+.container {
>+    height: 120px;
>+    width: 120px;
>+    position: relative;
>+    background-color: green;
>+}
>+
>+div div {
>+	background: blue;
>+    height: 10px;
>+}
>+</style>
>+<div class=container>
>+    <div style="width: 12px;"></div>
>+    <div style="width: 120px;"></div>
>+</div>
>diff --git a/LayoutTests/fast/block/block-only/absolute-positioned-min-max-percentage-with-parent-padding.html b/LayoutTests/fast/block/block-only/absolute-positioned-min-max-percentage-with-parent-padding.html
>new file mode 100644
>index 00000000000..c1d934ca31e
>--- /dev/null
>+++ b/LayoutTests/fast/block/block-only/absolute-positioned-min-max-percentage-with-parent-padding.html
>@@ -0,0 +1,21 @@
>+<style>
>+.container {
>+	padding: 10px;
>+    height: 100px;
>+    width: 100px;
>+    position: relative;
>+    background-color: green;
>+}
>+
>+div div {
>+	background: blue;
>+    position: absolute;
>+    top: 0px;
>+    left: 0px;
>+    height: 10px;
>+}
>+</style>
>+<div class=container>
>+    <div style="max-width: 10%; width: 100%;"></div>
>+    <div style="top: 10px; min-width: 100%; width: 10%;"></div>
>+</div>
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 650446d19dd..c6bc584d750 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-02-07  Zalan Bujtas  <zalan@apple.com>
>+
>+        [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
>+        https://bugs.webkit.org/show_bug.cgi?id=194391
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The spec is not clear about this but that's what matches the current behaviour.
>+
>+        Test: fast/block/block-only/absolute-positioned-min-max-percentage-with-parent-padding.html
>+
>+        * layout/FormattingContext.cpp:
>+        (WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
>+
> 2019-02-06  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Use dedicated data structures for optional used values (input to geometry functions)
>diff --git a/Source/WebCore/layout/FormattingContext.cpp b/Source/WebCore/layout/FormattingContext.cpp
>index 82a799a53fa..dc186975d60 100644
>--- a/Source/WebCore/layout/FormattingContext.cpp
>+++ b/Source/WebCore/layout/FormattingContext.cpp
>@@ -73,7 +73,7 @@ void FormattingContext::computeOutOfFlowHorizontalGeometry(const Box& layoutBox)
>     };
> 
>     auto horizontalGeometry = compute({ });
>-    auto containingBlockWidth = layoutState.displayBoxForLayoutBox(*layoutBox.containingBlock()).contentBoxWidth();
>+    auto containingBlockWidth = layoutState.displayBoxForLayoutBox(*layoutBox.containingBlock()).paddingBoxWidth();
> 
>     if (auto maxWidth = Geometry::computedValueIfNotAuto(layoutBox.style().logicalMaxWidth(), containingBlockWidth)) {
>         auto maxHorizontalGeometry = compute({ *maxWidth, { } });
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index bacdf01af6c..8b051e58e0c 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-02-07  Zalan Bujtas  <zalan@apple.com>
>+
>+        [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
>+        https://bugs.webkit.org/show_bug.cgi?id=194391
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * LayoutReloaded/misc/LFC-passing-tests.txt:
>+
> 2019-02-06  David Kilzer  <ddkilzer@apple.com>
> 
>         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
>diff --git a/Tools/LayoutReloaded/misc/LFC-passing-tests.txt b/Tools/LayoutReloaded/misc/LFC-passing-tests.txt
>index 71a47a6e2c1..ee63e0b7688 100644
>--- a/Tools/LayoutReloaded/misc/LFC-passing-tests.txt
>+++ b/Tools/LayoutReloaded/misc/LFC-passing-tests.txt
>@@ -96,6 +96,7 @@ fast/block/block-only/relative-position-when-containing-block-is-not-in-the-form
> fast/block/block-only/relative-right.html
> fast/block/block-only/relative-siblings.html
> fast/block/block-only/relative-simple.html
>+fast/block/block-only/absolute-positioned-min-max-percentage-with-parent-padding.html
> fast/block/basic/012.html
> fast/block/inside-inlines/crash-on-first-line-change.html
> fast/block/float/007.html

Actions: View | Formatted Diff | Diff

Attachments on bug 194391: 361394