Attachment 361324 Details for Bug 194357 – Patch

[patch] Patch

bug-194357-20190206134615.patch (text/plain), 8.72 KB, created by Keith Rollin on 2019-02-06 13:46:16 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Rollin

Created: 2019-02-06 13:46:16 PST

Size: 8.72 KB

patch

obsolete

>Subversion Revision: 241039
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 9477d74c1095fe02b00d2d2751e18b3b718745db..236609d51d835ce31fdcfcec6fadb49e9640e6c8 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2019-02-06  Keith Rollin  <krollin@apple.com>
>+
>+        Really enable the automatic checking and regenerations of .xcfilelists during builds
>+        https://bugs.webkit.org/show_bug.cgi?id=194357
>+        <rdar://problem/47861231>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Bug 194124 was supposed to enable the automatic checking and
>+        regenerating of .xcfilelist files during the build. While related
>+        changes were included in that patch, the change to actually enable the
>+        operation somehow was omitted. This patch actually enables the
>+        operation. The check-xcfilelist.sh scripts now check
>+        WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
>+        from the checking.
>+
>+        * Scripts/check-xcfilelists.sh:
>+
> 2019-02-06  Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         [JSC] Unify indirectEvalExecutableSpace and directEvalExecutableSpace
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 626d4f4dcc2480665b7ea7fe807f336d3ece1c97..c3ef9867afd17c494d359bc4c9e0cf3ffad5ddf6 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,23 @@
>+2019-02-06  Keith Rollin  <krollin@apple.com>
>+
>+        Really enable the automatic checking and regenerations of .xcfilelists during builds
>+        https://bugs.webkit.org/show_bug.cgi?id=194357
>+        <rdar://problem/47861231>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Bug 194124 was supposed to enable the automatic checking and
>+        regenerating of .xcfilelist files during the build. While related
>+        changes were included in that patch, the change to actually enable the
>+        operation somehow was omitted. This patch actually enables the
>+        operation. The check-xcfilelist.sh scripts now check
>+        WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
>+        from the checking.
>+
>+        No new tests since there should be no observable behavior difference.
>+
>+        * Scripts/check-xcfilelists.sh:
>+
> 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
> 
>         [SVG] fix SVGURIReference build by including SVGElement
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 21410d87caf3b1bff6270e6279089b7194cb14fe..251cc5679d1f143c6d653c6408c74d9fa2f3fa7c 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,21 @@
>+2019-02-06  Keith Rollin  <krollin@apple.com>
>+
>+        Really enable the automatic checking and regenerations of .xcfilelists during builds
>+        https://bugs.webkit.org/show_bug.cgi?id=194357
>+        <rdar://problem/47861231>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Bug 194124 was supposed to enable the automatic checking and
>+        regenerating of .xcfilelist files during the build. While related
>+        changes were included in that patch, the change to actually enable the
>+        operation somehow was omitted. This patch actually enables the
>+        operation. The check-xcfilelist.sh scripts now check
>+        WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
>+        from the checking.
>+
>+        * Scripts/check-xcfilelists.sh:
>+
> 2019-02-06  Per Arne Vollan  <pvollan@apple.com>
> 
>         Roll out parts of r238819 since it is a PLT performance regression.
>diff --git a/Source/JavaScriptCore/Scripts/check-xcfilelists.sh b/Source/JavaScriptCore/Scripts/check-xcfilelists.sh
>index 953dae273549424a79188b38b211b557d513201f..efb4ab1763d7c424ba27052c01b6eba8d8c1fb71 100755
>--- a/Source/JavaScriptCore/Scripts/check-xcfilelists.sh
>+++ b/Source/JavaScriptCore/Scripts/check-xcfilelists.sh
>@@ -1,6 +1,6 @@
> #!/bin/sh
> 
>-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
>+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
> [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
> [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
> 
>diff --git a/Source/WebCore/Scripts/check-xcfilelists.sh b/Source/WebCore/Scripts/check-xcfilelists.sh
>index c669a7de60d175e1a1c1ac3a62ab849c98db962a..585b950cdcf80a1ef12ae51748e300d34ba4b429 100755
>--- a/Source/WebCore/Scripts/check-xcfilelists.sh
>+++ b/Source/WebCore/Scripts/check-xcfilelists.sh
>@@ -1,6 +1,6 @@
> #!/bin/sh
> 
>-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
>+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
> [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
> [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
> 
>diff --git a/Source/WebKit/Scripts/check-xcfilelists.sh b/Source/WebKit/Scripts/check-xcfilelists.sh
>index 8e836f12599600eadee39dc414ea4cc4dfa85659..1150a4f60b2652d8bf28782d6b099209c2e10f08 100755
>--- a/Source/WebKit/Scripts/check-xcfilelists.sh
>+++ b/Source/WebKit/Scripts/check-xcfilelists.sh
>@@ -1,6 +1,6 @@
> #!/bin/sh
> 
>-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
>+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
> [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
> [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
> 
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index bacdf01af6c6ccaa713eb49f1c76cbee2710029c..c3fe06c0f1b8309bcb69ecec43d8e3ec0b61a2b2 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-02-06  Keith Rollin  <krollin@apple.com>
>+
>+        Really enable the automatic checking and regenerations of .xcfilelists during builds
>+        https://bugs.webkit.org/show_bug.cgi?id=194357
>+        <rdar://problem/47861231>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Bug 194124 was supposed to enable the automatic checking and
>+        regenerating of .xcfilelist files during the build. While related
>+        changes were included in that patch, the change to actually enable the
>+        operation somehow was omitted. This patch actually enables the
>+        operation. The check-xcfilelist.sh scripts now check
>+        WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
>+        from the checking.
>+
>+        * DumpRenderTree/Scripts/check-xcfilelists.sh:
>+        * WebKitTestRunner/Scripts/check-xcfilelists.sh:
>+
> 2019-02-06  David Kilzer  <ddkilzer@apple.com>
> 
>         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
>diff --git a/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh b/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh
>index 8a087734d959e39880f7ffc9a16bf45303542de9..b18acb3226edec7a7d9875856583987ce256be86 100755
>--- a/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh
>+++ b/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh
>@@ -1,6 +1,6 @@
> #!/bin/sh
> 
>-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
>+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
> [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
> [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
> 
>diff --git a/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh b/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh
>index 730145c46d6080ea0ba6ebea567754a484027340..7e89950bc3bd6450206cfe810bac34ce4d2dcae9 100755
>--- a/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh
>+++ b/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh
>@@ -1,6 +1,6 @@
> #!/bin/sh
> 
>-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
>+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
> [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
> [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194357: 361324