WebKit Bugzilla
Attachment 361323 Details for
Bug 194359
: Fix potential build error in GPUDevice
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194359-20190207084206.patch (text/plain), 1.41 KB, created by
Dean Jackson
on 2019-02-06 13:42:07 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Dean Jackson
Created:
2019-02-06 13:42:07 PST
Size:
1.41 KB
patch
obsolete
>Subversion Revision: 240985 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 6ebd36c6181f4d2a1cd97db58dc5d851fd5c781d..139ee118615d661c4c9e0f4acca0bd5dea8c2cee 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,15 @@ >+2019-02-06 Dean Jackson <dino@apple.com> >+ >+ Fix potential build error in GPUDevice >+ https://bugs.webkit.org/show_bug.cgi?id=194359 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Add an UNUSED_PARAM for non-macOS platforms. >+ >+ * platform/graphics/gpu/cocoa/GPUDeviceMetal.mm: >+ (WebCore::GPUDevice::create): >+ > 2019-02-05 Alex Christensen <achristensen@webkit.org> > > Stop using blobRegistry in NetworkProcess >diff --git a/Source/WebCore/platform/graphics/gpu/cocoa/GPUDeviceMetal.mm b/Source/WebCore/platform/graphics/gpu/cocoa/GPUDeviceMetal.mm >index c76ec8b1bb3b2d4c889503bab3311cac6e7d0db9..cde1fabc130be482073f8fd87d86fb69452aa228 100644 >--- a/Source/WebCore/platform/graphics/gpu/cocoa/GPUDeviceMetal.mm >+++ b/Source/WebCore/platform/graphics/gpu/cocoa/GPUDeviceMetal.mm >@@ -55,8 +55,10 @@ RefPtr<GPUDevice> GPUDevice::create(Optional<GPURequestAdapterOptions>&& options > } > > if (!devicePtr) >+#else >+ UNUSED_PARAM(options); > #endif // PLATFORM(MAC) >- devicePtr = adoptNS(MTLCreateSystemDefaultDevice()); >+ devicePtr = adoptNS(MTLCreateSystemDefaultDevice()); > > END_BLOCK_OBJC_EXCEPTIONS; >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
joepeck
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194359
: 361323