WebKit Bugzilla
Attachment 361292 Details for
Bug 194341
: Build failure after r240315
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
patch
bug-194341-20190206142609.patch (text/plain), 1.80 KB, created by
Pablo Saavedra
on 2019-02-06 05:26:10 PST
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
Pablo Saavedra
Created:
2019-02-06 05:26:10 PST
Size:
1.80 KB
patch
obsolete
>Subversion Revision: 241015 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 76da75cb9ade9294c2662b05d6b433b3ce5307c2..f10ae12db777d51bb9f02811d4aa8927af20b57a 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,13 @@ >+2019-02-06 Pablo Saavedra <psaavedra@igalia.com> >+ >+ Build failure after r240315 >+ https://bugs.webkit.org/show_bug.cgi?id=194341 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * bindings/js/JSUndoItemCustom.cpp: >+ (WebCore::JSUndoItemOwner::isReachableFromOpaqueRoots): >+ > 2019-02-05 Ryosuke Niwa <rniwa@webkit.org> > > REGRESSION (r240909): Release assert in FrameLoader::loadURL when navigating with a non-existent target name >diff --git a/Source/WebCore/bindings/js/JSUndoItemCustom.cpp b/Source/WebCore/bindings/js/JSUndoItemCustom.cpp >index cfaa028bbff5fd5b4a3f4a0d61010fcbe653fc75..3f6dd9fd00d8442105fa411ac65838c15c1c14d9 100644 >--- a/Source/WebCore/bindings/js/JSUndoItemCustom.cpp >+++ b/Source/WebCore/bindings/js/JSUndoItemCustom.cpp >@@ -34,12 +34,12 @@ void JSUndoItem::visitAdditionalChildren(JSC::SlotVisitor& visitor) > wrapped().redoHandler().visitJSFunction(visitor); > } > >-bool JSUndoItemOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor, const char** reason) >+bool JSUndoItemOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, JSC::SlotVisitor& visitor, const char** reason) > { > if (UNLIKELY(reason)) > *reason = "Document is an opaque root."; > >- auto* documentForUndoItem = jsCast<JSUndoItem*>(handle.slot()->asCell())->wrapped().document(); >+ auto* documentForUndoItem = JSC::jsCast<JSUndoItem*>(handle.slot()->asCell())->wrapped().document(); > return documentForUndoItem && visitor.containsOpaqueRoot(documentForUndoItem); > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194341
: 361292