Attachment 361289 Details for Bug 194292 – Patch

[patch] Patch

bug-194292-20190206140450.patch (text/plain), 1.69 KB, created by Olivier Blin on 2019-02-06 05:04:51 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Blin

Created: 2019-02-06 05:04:51 PST

Size: 1.69 KB

patch

obsolete

>Subversion Revision: 240968
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index c11ea8c63593f92606861512b54504dfbbdf9c04..d09ce20333c8c9a0a584881501a3564335583e0a 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
>+
>+        [SVG] fix SVGURIReference build by including SVGElement
>+        https://bugs.webkit.org/show_bug.cgi?id=194292
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * svg/SVGURIReference.h:
>+        SVGURIReference is making use of SVGElement in its constructor, but
>+        it was not declared.
>+
>+        The issue was not seen in unified builds because it was grouped with
>+        other files including SVGElement.
>+
> 2019-02-05  Benjamin Poulain  <benjamin@webkit.org>
> 
>         Hit testing functions optimizations
>diff --git a/Source/WebCore/svg/SVGURIReference.cpp b/Source/WebCore/svg/SVGURIReference.cpp
>index 2373cb4978d7d7722ae23b08746dd22619481c5f..998e2f4c25635841f920b2391d0aa914d79cd25b 100644
>--- a/Source/WebCore/svg/SVGURIReference.cpp
>+++ b/Source/WebCore/svg/SVGURIReference.cpp
>@@ -25,6 +25,7 @@
> #include "Document.h"
> #include "Element.h"
> #include "SVGAttributeOwnerProxy.h"
>+#include "SVGElement.h"
> #include <wtf/URL.h>
> #include "XLinkNames.h"
> 
>diff --git a/Source/WebCore/svg/SVGURIReference.h b/Source/WebCore/svg/SVGURIReference.h
>index f4629e05e0cd723e1c6e6eb1d3d58ba8be0800d7..660c262630742a9ca28febbc7daaa7e81e2a5ed9 100644
>--- a/Source/WebCore/svg/SVGURIReference.h
>+++ b/Source/WebCore/svg/SVGURIReference.h
>@@ -27,6 +27,8 @@
> 
> namespace WebCore {
> 
>+class SVGElement;
>+
> template<typename OwnerType, typename... BaseTypes>
> class SVGAttributeRegistry;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194292: 361198 | 361289