Attachment 361265 Details for Bug 194324 – Patch

[patch] Patch

bug-194324-20190205185349.patch (text/plain), 5.25 KB, created by Wenson Hsieh on 2019-02-05 18:53:49 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2019-02-05 18:53:49 PST

Size: 5.25 KB

patch

obsolete

>Subversion Revision: 241005
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 5e72be5b595b4a2f663eb4c7acb3485c2492138a..59814ba2884a086e581d74e0510b1f74459d141f 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
>+        https://bugs.webkit.org/show_bug.cgi?id=194324
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
>+        part of the name is already implicit, since this is in testing code in TestOptions.
>+
>+        * WebKitTestRunner/TestController.cpp:
>+        (WTR::TestController::generateContextConfiguration const):
>+        (WTR::updateTestOptionsFromTestHeader):
>+        * WebKitTestRunner/TestOptions.h:
>+        (WTR::TestOptions::hasSameInitializationOptions const):
>+
> 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
> 
>         [ews-build] Allow * as platform for builders and workers
>diff --git a/Tools/WebKitTestRunner/TestController.cpp b/Tools/WebKitTestRunner/TestController.cpp
>index 172e809c4222df88ca21b770ee9b2abfa6f37bcd..4cc4cccc0f023876de4a00dab367ec8c681ac29b 100644
>--- a/Tools/WebKitTestRunner/TestController.cpp
>+++ b/Tools/WebKitTestRunner/TestController.cpp
>@@ -458,7 +458,7 @@ WKRetainPtr<WKContextConfigurationRef> TestController::generateContextConfigurat
>     auto configuration = adoptWK(WKContextConfigurationCreate());
>     WKContextConfigurationSetInjectedBundlePath(configuration.get(), injectedBundlePath());
>     WKContextConfigurationSetFullySynchronousModeIsAllowedForTesting(configuration.get(), true);
>-    WKContextConfigurationSetIgnoreSynchronousMessagingTimeoutsForTesting(configuration.get(), options.ignoreSynchronousMessagingTimeoutsForTesting);
>+    WKContextConfigurationSetIgnoreSynchronousMessagingTimeoutsForTesting(configuration.get(), options.ignoreSynchronousMessagingTimeouts);
> 
>     if (const char* dumpRenderTreeTemp = libraryPathForTesting()) {
>         String temporaryFolder = String::fromUTF8(dumpRenderTreeTemp);
>@@ -1286,8 +1286,8 @@ static void updateTestOptionsFromTestHeader(TestOptions& testOptions, const std:
>             testOptions.enableUndoManagerAPI = parseBooleanTestHeaderValue(value);
>         else if (key == "contentInset.top")
>             testOptions.contentInsetTop = std::stod(value);
>-        else if (key == "ignoreSynchronousMessagingTimeoutsForTesting")
>-            testOptions.ignoreSynchronousMessagingTimeoutsForTesting = parseBooleanTestHeaderValue(value);
>+        else if (key == "ignoreSynchronousMessagingTimeouts")
>+            testOptions.ignoreSynchronousMessagingTimeouts = parseBooleanTestHeaderValue(value);
>         pairStart = pairEnd + 1;
>     }
> }
>diff --git a/Tools/WebKitTestRunner/TestOptions.h b/Tools/WebKitTestRunner/TestOptions.h
>index f91dd50c9d206b03d3f380b75a81d09523eefcbc..0ac586eb1eabe5e1901cad638b648328a74ea882 100644
>--- a/Tools/WebKitTestRunner/TestOptions.h
>+++ b/Tools/WebKitTestRunner/TestOptions.h
>@@ -68,7 +68,7 @@ struct TestOptions {
>     bool enableEditableImages { false };
>     bool editable { false };
>     bool enableUndoManagerAPI { false };
>-    bool ignoreSynchronousMessagingTimeoutsForTesting { false };
>+    bool ignoreSynchronousMessagingTimeouts { false };
> 
>     double contentInsetTop { 0 };
> 
>@@ -118,7 +118,7 @@ struct TestOptions {
>             || editable != options.editable
>             || enableUndoManagerAPI != options.enableUndoManagerAPI
>             || contentInsetTop != options.contentInsetTop
>-            || ignoreSynchronousMessagingTimeoutsForTesting != options.ignoreSynchronousMessagingTimeoutsForTesting)
>+            || ignoreSynchronousMessagingTimeouts != options.ignoreSynchronousMessagingTimeouts)
>             return false;
> 
>         if (experimentalFeatures != options.experimentalFeatures)
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 74908a7fa06567b5bd8e5dc2c62e2aca801455b4..fceb2afee97f19a9a302f7d199078758dce90fef 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
>+        https://bugs.webkit.org/show_bug.cgi?id=194324
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * fast/events/touch/ios/show-modal-alert-during-touch-start.html:
>+
> 2019-02-05  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Fix modify-css-property-race.html test failures
>diff --git a/LayoutTests/fast/events/touch/ios/show-modal-alert-during-touch-start.html b/LayoutTests/fast/events/touch/ios/show-modal-alert-during-touch-start.html
>index 9b3abc04b5250d42bc649b787d9ca1e23e2fadfd..00328174de2f85f3efd6411415db8f2a8f8fbaab 100644
>--- a/LayoutTests/fast/events/touch/ios/show-modal-alert-during-touch-start.html
>+++ b/LayoutTests/fast/events/touch/ios/show-modal-alert-during-touch-start.html
>@@ -1,4 +1,4 @@
>-<!DOCTYPE html> 
>+<!DOCTYPE html> 
> <html>
> <head>
> <meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=no">

Actions: View | Formatted Diff | Diff

Attachments on bug 194324: 361265