Attachment 361247 Details for Bug 194320 – Patch

[patch] Patch

bug-194320-20190205164600.patch (text/plain), 2.31 KB, created by Megan Gardner on 2019-02-05 16:46:00 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2019-02-05 16:46:00 PST

Size: 2.31 KB

patch

obsolete

>Subversion Revision: 240947
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 0cf299f3fe9709f00a54a5c80ca1c00546d42cfc..ef3da97a0b4d29b07ff4eb03b09fed2d7a687d49 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-02-05  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Turn On Smart Delete
>+        https://bugs.webkit.org/show_bug.cgi?id=194320
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        * editing/Editor.cpp:
>+        (WebCore::Editor::canSmartCopyOrDelete):
>+        (WebCore::Editor::performCutOrCopy):
>+        * editing/Editor.h:
>+
> 2019-02-04  Justin Fan  <justin_fan@apple.com>
> 
>         [Web GPU] Code clean-up for RenderPipeline backend
>diff --git a/Source/WebCore/editing/Editor.cpp b/Source/WebCore/editing/Editor.cpp
>index df190e5d396cb9677c9c4d3087aacc3827ea32bb..6a22444f1cfc22ec35a5bc85c0884f1858cceef9 100644
>--- a/Source/WebCore/editing/Editor.cpp
>+++ b/Source/WebCore/editing/Editor.cpp
>@@ -519,7 +519,11 @@ bool Editor::smartInsertDeleteEnabled()
>     
> bool Editor::canSmartCopyOrDelete()
> {
>+#if PLATFORM(IOS)
>+    return client() && client()->smartInsertDeleteEnabled();
>+#else
>     return client() && client()->smartInsertDeleteEnabled() && m_frame.selection().granularity() == WordGranularity;
>+#endif
> }
> 
> bool Editor::isSelectTrailingWhitespaceEnabled() const
>@@ -1376,7 +1380,6 @@ void Editor::performCutOrCopy(EditorActionSpecifier action)
> 
>         updateMarkersForWordsAffectedByEditing(true);
>     }
>-
>     if (enclosingTextFormControl(m_frame.selection().selection().start()))
>         Pasteboard::createForCopyAndPaste()->writePlainText(selectedTextForDataTransfer(), canSmartCopyOrDelete() ? Pasteboard::CanSmartReplace : Pasteboard::CannotSmartReplace);
>     else {
>diff --git a/Source/WebCore/editing/Editor.h b/Source/WebCore/editing/Editor.h
>index 4547d4715f9833a867ce7f6a833378c5363d03bb..b37335eebe4a24d36a879c29fe465358b7577760 100644
>--- a/Source/WebCore/editing/Editor.h
>+++ b/Source/WebCore/editing/Editor.h
>@@ -165,7 +165,7 @@ public:
>     WEBCORE_EXPORT bool canCopy() const;
>     WEBCORE_EXPORT bool canPaste() const;
>     WEBCORE_EXPORT bool canDelete() const;
>-    bool canSmartCopyOrDelete();
>+    WEBCORE_EXPORT bool canSmartCopyOrDelete();
> 
>     WEBCORE_EXPORT void cut();
>     WEBCORE_EXPORT void copy();

Actions: View | Formatted Diff | Diff

Attachments on bug 194320: 361247 | 361269 | 361725 | 361728 | 361753 | 361816 | 361821 | 361823 | 361831 | 361834 | 361858 | 361867 | 361877 | 361887 | 361888 | 361949 | 361960 | 361968 | 361975 | 361977 | 362003 | 362018 | 362032 | 362035 | 362077 | 362082 | 362087 | 362088 | 362112 | 362116 | 362121 | 362125 | 362130 | 362131 | 362132 | 362142 | 362145 | 362150 | 362151 | 362183 | 362298