Attachment 361244 Details for Bug 194316 – Patch

[patch] Patch

bug-194316-20190205164232.patch (text/plain), 28.68 KB, created by Yusuke Suzuki on 2019-02-05 16:42:33 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2019-02-05 16:42:33 PST

Size: 28.68 KB

patch

obsolete

>Subversion Revision: 240999
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index fb8389d38d980e86d6792f3b8103ca902ad6f5e2..08a9c264e3dfbfc20d8f1bd0777c92ec12114e9c 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,39 @@
>+2019-02-05  Yusuke Suzuki  <ysuzuki@apple.com>
>+
>+        [JSC] Use Fast Malloc as much as possible
>+        https://bugs.webkit.org/show_bug.cgi?id=194316
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We should use Fast Malloc as much as possible to offer the whole memory view to bmalloc.
>+
>+        * inspector/scripts/codegen/cpp_generator_templates.py:
>+        * inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
>+        * inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
>+        * inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
>+        * inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result:
>+        * inspector/scripts/tests/generic/expected/domain-availability.json-result:
>+        * inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result:
>+        * inspector/scripts/tests/generic/expected/enum-values.json-result:
>+        * inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
>+        * inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
>+        * inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result:
>+        * inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result:
>+        * inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result:
>+        * inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result:
>+        * inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result:
>+        * inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:
>+        * inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
>+        * inspector/scripts/tests/generic/expected/type-with-open-parameters.json-result:
>+        * inspector/scripts/tests/generic/expected/version.json-result:
>+        * inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result:
>+        * inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:
>+        * jit/ExecutableAllocator.h:
>+        * jsc.cpp:
>+        * runtime/JSRunLoopTimer.h:
>+        * tools/VMInspector.h:
>+        * wasm/WasmThunks.h:
>+
> 2019-02-05  Mark Lam  <mark.lam@apple.com>
> 
>         Fix DFG's doesGC() for a few more nodes.
>diff --git a/Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator_templates.py b/Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator_templates.py
>index fe4fb2c67d7ca88f957d27c98e653362c7492fe6..ad9b701490a7dd7ad5ac3d54d5651d9ae006c3c0 100755
>--- a/Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator_templates.py
>+++ b/Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator_templates.py
>@@ -63,6 +63,7 @@ class CppGeneratorTemplates:
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>@@ -85,6 +86,7 @@ class AlternateBackendDispatcher {
> 
>     BackendDispatcherHeaderDomainHandlerDeclaration = (
>     """${classAndExportMacro} ${domainName}BackendDispatcherHandler {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
> ${commandDeclarations}
> protected:
>@@ -196,6 +198,7 @@ class AlternateBackendDispatcher {
> 
>     FrontendDispatcherDomainDispatcherDeclaration = (
> """${classAndExportMacro} ${domainName}FrontendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     ${domainName}FrontendDispatcher(FrontendRouter& frontendRouter) : m_frontendRouter(frontendRouter) { }
> ${eventDeclarations}
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result b/Source/JavaScriptCore/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result
>index 1234ca92e4d9fbbd477f7368bfa8cede94eb84f3..7175b1b6b4eefc1a4bf302e5c54acf7bd25f03aa 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result
>@@ -78,6 +78,7 @@ InspectorBackend.activateDomain("Network");
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>@@ -143,6 +144,7 @@ class AlternateNetworkBackendDispatcher;
> #endif // ENABLE(INSPECTOR_ALTERNATE_DISPATCHERS)
> 
> class NetworkBackendDispatcherHandler {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     virtual void loadResource(ErrorString&) = 0;
> protected:
>@@ -306,6 +308,7 @@ namespace Inspector {
> class FrontendRouter;
> 
> class NetworkFrontendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     NetworkFrontendDispatcher(FrontendRouter& frontendRouter) : m_frontendRouter(frontendRouter) { }
>     void resourceLoaded();
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result
>index c976f0ba07578337351611c74e4a8476167bbd83..aa6f8c25d2a869f0e53457663eb5911fe1976c7e 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result
>@@ -81,6 +81,7 @@ InspectorBackend.activateDomain("Database");
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>@@ -149,6 +150,7 @@ class AlternateDatabaseBackendDispatcher;
> #endif // ENABLE(INSPECTOR_ALTERNATE_DISPATCHERS)
> 
> class DatabaseBackendDispatcherHandler {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     // Named after parameter 'printColor' while generating command/event executeSQLSyncOptionalReturnValues.
>     enum class PrintColor {
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result
>index 71e8915cec216b4cb32321b0b96edff7d938af34..e037ae29bd578e3cd73514f7d2b43c35fb81ad5c 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result
>@@ -78,6 +78,7 @@ InspectorBackend.activateDomain("Database");
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>@@ -144,6 +145,7 @@ class AlternateDatabaseBackendDispatcher;
> #endif // ENABLE(INSPECTOR_ALTERNATE_DISPATCHERS)
> 
> class DatabaseBackendDispatcherHandler {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     // Named after parameter 'printColor' while generating command/event executeAllOptionalParameters.
>     enum class PrintColor {
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result
>index a90d580ad4b9d545cbdb8539a8d66b86167bc435..d6432e52582c2f259a67daaea5c3ae52464e5705 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result
>@@ -72,6 +72,7 @@
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/domain-availability.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/domain-availability.json-result
>index 678c6aaa85aca384248b9929034ccf094118dee7..f4df723360ec81ef6f4a3b175f975a092901403d 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/domain-availability.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/domain-availability.json-result
>@@ -80,6 +80,7 @@ InspectorBackend.activateDomain("DomainB");
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>@@ -151,6 +152,7 @@ class AlternateDomainBBackendDispatcher;
> #endif // ENABLE(INSPECTOR_ALTERNATE_DISPATCHERS)
> 
> class DomainABackendDispatcherHandler {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     virtual void enable(ErrorString&) = 0;
> protected:
>@@ -158,6 +160,7 @@ protected:
> };
> 
> class DomainBBackendDispatcherHandler {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     virtual void enable(ErrorString&) = 0;
> protected:
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result
>index f6c5edccb9285af48c6deb98422a7236b8702d4e..ff2b0eb6184897b6f9edf99a9a8d6d8ce82e0365 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result
>@@ -86,6 +86,7 @@ InspectorBackend.activateDomain("Network3");
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>@@ -163,6 +164,7 @@ class AlternateNetwork3BackendDispatcher;
> #endif // ENABLE(INSPECTOR_ALTERNATE_DISPATCHERS)
> 
> class Network1BackendDispatcherHandler {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     virtual void loadResource1(ErrorString&) = 0;
> protected:
>@@ -170,6 +172,7 @@ protected:
> };
> 
> class Network3BackendDispatcherHandler {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     virtual void loadResource1(ErrorString&) = 0;
>     virtual void loadResource2(ErrorString&) = 0;
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/enum-values.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/enum-values.json-result
>index ff6e9e02b7703d1878a36fb9b834f53b6412c373..a4875769047594a0973265ea28e8a17ea5f0cde2 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/enum-values.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/enum-values.json-result
>@@ -86,6 +86,7 @@ InspectorBackend.activateDomain("EventDomain");
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>@@ -151,6 +152,7 @@ class AlternateCommandDomainBackendDispatcher;
> #endif // ENABLE(INSPECTOR_ALTERNATE_DISPATCHERS)
> 
> class CommandDomainBackendDispatcherHandler {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     // Named after parameter 'returnValue' while generating command/event commandWithEnumReturnValue.
>     enum class ReturnValue {
>@@ -325,6 +327,7 @@ namespace Inspector {
> class FrontendRouter;
> 
> class EventDomainFrontendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     EventDomainFrontendDispatcher(FrontendRouter& frontendRouter) : m_frontendRouter(frontendRouter) { }
>         // Named after parameter 'parameter' while generating command/event eventWithEnumParameter.
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result
>index 8f743f57abb2aaa7907021fd0db7185ecd72bbff..41ce3e64503795650cbcb3c6d3eb13f9f654c3c4 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result
>@@ -78,6 +78,7 @@ InspectorBackend.activateDomain("Database");
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>@@ -232,6 +233,7 @@ namespace Inspector {
> class FrontendRouter;
> 
> class DatabaseFrontendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     DatabaseFrontendDispatcher(FrontendRouter& frontendRouter) : m_frontendRouter(frontendRouter) { }
>     void didExecuteOptionalParameters(RefPtr<JSON::ArrayOf<String>> columnNames, const String* notes, const double* timestamp, RefPtr<JSON::Object> values, RefPtr<JSON::Value> payload, RefPtr<Inspector::Protocol::Database::Error> sqlError, const String* screenColor, RefPtr<Inspector::Protocol::Database::ColorList> alternateColors, const String* printColor);
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result
>index b5f9e6a183c37a030c2b67af7f7b060e7b262137..987213013087395322d24afe5acb335d59483faa 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result
>@@ -81,6 +81,7 @@ InspectorBackend.activateDomain("Network3");
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>@@ -151,6 +152,7 @@ class AlternateNetwork1BackendDispatcher;
> 
> #if PLATFORM(WEB_COMMANDS)
> class Network1BackendDispatcherHandler {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     virtual void loadResource(ErrorString&) = 0;
> protected:
>@@ -322,6 +324,7 @@ class FrontendRouter;
> 
> #if PLATFORM(WEB_EVENTS)
> class Network3FrontendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     Network3FrontendDispatcher(FrontendRouter& frontendRouter) : m_frontendRouter(frontendRouter) { }
>     void resourceLoaded();
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result
>index e457f9a4b78c8571b16e9bfe9528b4240b2a976f..f024be29038da84542f4967478530a691a556872 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result
>@@ -72,6 +72,7 @@
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result
>index a89d190ae98a28f2bd1135c704fffdcbeac71018..bc3a787312ca6ba37d243d12b62cb363ac14ea0d 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result
>@@ -72,6 +72,7 @@
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result
>index d9d6838901b028eacb3461e26d64932f71c14d1e..8c49d0d1c9e8063920f9c559dec6074c9a4136eb 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result
>@@ -72,6 +72,7 @@
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result
>index a6b3c30c3de56287772cd24911969b53729dd723..45c5d78651b71389de5be74d2a631aaf9012a9b3 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result
>@@ -76,6 +76,7 @@ InspectorBackend.activateDomain("Debugger");
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result
>index 44a968675a829bbd72b1d31b886438ab85d355c6..77d126bb30aab15a4304203910b72305b562c73e 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result
>@@ -77,6 +77,7 @@ InspectorBackend.activateDomain("Runtime");
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result
>index 0bfc0abb6e62495322273a349da19e6ad183d3e7..09fbd4faeb0ce8f260429ab4593e8b144427c11a 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result
>@@ -78,6 +78,7 @@ InspectorBackend.activateDomain("Database");
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result
>index 76d7e10833073f249083a83ecb3027bffb8d53e6..b801b5bf3998458fe891eb3760357a1f3b3b4a79 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result
>@@ -77,6 +77,7 @@ InspectorBackend.activateDomain("Test");
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-with-open-parameters.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-with-open-parameters.json-result
>index c49c3a50ee5ea53a570bfcafade17d1c967f82fd..e62ca84cb57c324487bff0e25d8a97f612507914 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-with-open-parameters.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/type-with-open-parameters.json-result
>@@ -72,6 +72,7 @@
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/version.json-result b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/version.json-result
>index 302b7e4e942b3fc71d63542348b2e0c4a516979e..2feaca75fc487a27c43e35c9d9e271af14f02bed 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/version.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/generic/expected/version.json-result
>@@ -76,6 +76,7 @@ InspectorBackend.activateDomain("VersionDomain");
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result b/Source/JavaScriptCore/inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result
>index a90d580ad4b9d545cbdb8539a8d66b86167bc435..d6432e52582c2f259a67daaea5c3ae52464e5705 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result
>@@ -72,6 +72,7 @@
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>diff --git a/Source/JavaScriptCore/inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result b/Source/JavaScriptCore/inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result
>index 1234ca92e4d9fbbd477f7368bfa8cede94eb84f3..7175b1b6b4eefc1a4bf302e5c54acf7bd25f03aa 100644
>--- a/Source/JavaScriptCore/inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result
>+++ b/Source/JavaScriptCore/inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result
>@@ -78,6 +78,7 @@ InspectorBackend.activateDomain("Network");
> namespace Inspector {
> 
> class AlternateBackendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     void setBackendDispatcher(RefPtr<BackendDispatcher>&& dispatcher) { m_backendDispatcher = WTFMove(dispatcher); }
>     BackendDispatcher* backendDispatcher() const { return m_backendDispatcher.get(); }
>@@ -143,6 +144,7 @@ class AlternateNetworkBackendDispatcher;
> #endif // ENABLE(INSPECTOR_ALTERNATE_DISPATCHERS)
> 
> class NetworkBackendDispatcherHandler {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     virtual void loadResource(ErrorString&) = 0;
> protected:
>@@ -306,6 +308,7 @@ namespace Inspector {
> class FrontendRouter;
> 
> class NetworkFrontendDispatcher {
>+    WTF_MAKE_FAST_ALLOCATED;
> public:
>     NetworkFrontendDispatcher(FrontendRouter& frontendRouter) : m_frontendRouter(frontendRouter) { }
>     void resourceLoaded();
>diff --git a/Source/JavaScriptCore/jit/ExecutableAllocator.h b/Source/JavaScriptCore/jit/ExecutableAllocator.h
>index 13ed346cd90552d7200c84f20641ec5a207f9a14..bb98f520e2b46aabb1d4212b6a2ac080895ad16d 100644
>--- a/Source/JavaScriptCore/jit/ExecutableAllocator.h
>+++ b/Source/JavaScriptCore/jit/ExecutableAllocator.h
>@@ -123,6 +123,8 @@ static inline void* performJITMemcpy(void *dst, const void *src, size_t n)
> }
> 
> class ExecutableAllocator {
>+    WTF_MAKE_FAST_ALLOCATED;
>+    WTF_MAKE_NONCOPYABLE(ExecutableAllocator);
>     enum ProtectionSetting { Writable, Executable };
> 
> public:
>diff --git a/Source/JavaScriptCore/jsc.cpp b/Source/JavaScriptCore/jsc.cpp
>index be0180605e6e8abf48ab711b86c9d4fc98c05f1a..9b8f3be7867e51895a468a9747199226ab1ddd8a 100644
>--- a/Source/JavaScriptCore/jsc.cpp
>+++ b/Source/JavaScriptCore/jsc.cpp
>@@ -254,6 +254,8 @@ class Worker : public BasicRawSentinelNode<Worker> {
> };
> 
> class Workers {
>+    WTF_MAKE_FAST_ALLOCATED;
>+    WTF_MAKE_NONCOPYABLE(Workers);
> public:
>     Workers();
>     ~Workers();
>diff --git a/Source/JavaScriptCore/runtime/JSRunLoopTimer.h b/Source/JavaScriptCore/runtime/JSRunLoopTimer.h
>index b9a2f43a8798aaa316c5d5f5ea3625fc00b174d8..3626ab6b6cd63eb95112dff9068c9d3f405d93b7 100644
>--- a/Source/JavaScriptCore/runtime/JSRunLoopTimer.h
>+++ b/Source/JavaScriptCore/runtime/JSRunLoopTimer.h
>@@ -48,11 +48,14 @@ class JSRunLoopTimer : public ThreadSafeRefCounted<JSRunLoopTimer> {
>     using TimerNotificationCallback = RefPtr<WTF::SharedTask<TimerNotificationType>>;
> 
>     class Manager {
>+        WTF_MAKE_FAST_ALLOCATED;
>+        WTF_MAKE_NONCOPYABLE(Manager);
> #if USE(CF)
>         static void timerDidFireCallback(CFRunLoopTimerRef, void*);
> #else
>         void timerDidFireCallback();
> #endif
>+        Manager() = default;
> 
>         void timerDidFire();
> 
>diff --git a/Source/JavaScriptCore/tools/VMInspector.h b/Source/JavaScriptCore/tools/VMInspector.h
>index 3f3f33b7eb3c953e68d6288d2756f667e9809b50..3a3b7ee3f4e47dd4800df6f4baa510ccc31e17af 100644
>--- a/Source/JavaScriptCore/tools/VMInspector.h
>+++ b/Source/JavaScriptCore/tools/VMInspector.h
>@@ -34,6 +34,9 @@
> namespace JSC {
> 
> class VMInspector {
>+    WTF_MAKE_FAST_ALLOCATED;
>+    WTF_MAKE_NONCOPYABLE(VMInspector);
>+    VMInspector() = default;
> public:
>     enum class Error {
>         None,
>diff --git a/Source/JavaScriptCore/wasm/WasmThunks.h b/Source/JavaScriptCore/wasm/WasmThunks.h
>index cc05b6db7041e304c9af7f991315f79591b619f0..f92fa5dbae270f0a38039ae6c9398fb453790744 100644
>--- a/Source/JavaScriptCore/wasm/WasmThunks.h
>+++ b/Source/JavaScriptCore/wasm/WasmThunks.h
>@@ -39,6 +39,8 @@ MacroAssemblerCodeRef<JITThunkPtrTag> triggerOMGTierUpThunkGenerator(const Abstr
> typedef MacroAssemblerCodeRef<JITThunkPtrTag> (*ThunkGenerator)(const AbstractLocker&);
> 
> class Thunks {
>+    WTF_MAKE_FAST_ALLOCATED;
>+    WTF_MAKE_NONCOPYABLE(Thunks);
> public:
>     static void initialize();
>     static Thunks& singleton();

Flags:

mark.lam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 194316: 361244 | 362660