Attachment 361234 Details for Bug 194306 – patch

[patch] patch

patch (text/plain), 1.57 KB, created by chris fleizach on 2019-02-05 15:49:31 PST

(hide)

Description:

Filename:

MIME Type:

Creator: chris fleizach

Created: 2019-02-05 15:49:31 PST

Size: 1.57 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 240998)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-02-05  chris fleizach  <cfleizach@apple.com>
>+
>+        AX:  com.apple.WebKit.WebContent at WebKit: -[WKAccessibilityWebPageObjectBase axObjectCache]
>+        https://bugs.webkit.org/show_bug.cgi?id=194306
>+        <rdar://problem/47764549>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Check the page reference is still valid.
>+        Modernize code in this area.
>+
>+        * WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:
>+
> 2019-02-05  Tim Horton  <timothy_horton@apple.com>
> 
>         Reproducible crash under WKShareSheet presentWithParameters when cancelling a share
>Index: Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm
>===================================================================
>--- Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm	(revision 240993)
>+++ Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm	(working copy)
>@@ -50,12 +50,16 @@
> 
> - (WebCore::AXObjectCache*)axObjectCache
> {
>-    WebCore::Page* page = m_page->corePage();
>+    if (!m_page)
>+        return nullptr;
>+
>+    auto page = m_page->corePage();
>     if (!page)
>-        return nil;
>-    WebCore::Frame& core = page->mainFrame();
>+        return nullptr;
>+
>+    auto& core = page->mainFrame();
>     if (!core.document())
>-        return nil;
>+        return nullptr;
> 
>     return core.document()->axObjectCache();
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 194306: 361230 | 361234