Attachment 361223 Details for Bug 159577 – Patch

[patch] Patch

bug-159577-20190205150100.patch (text/plain), 3.04 KB, created by Devin Rousso on 2019-02-05 15:01:00 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-02-05 15:01:00 PST

Size: 3.04 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index d9f248038f25173c7379fb774c42d1afaf27f9a7..f7edaf0b399fc2ea44cbe2ea2e0331dfda7bab46 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-02-05  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Lots of time spent updating related resources in ResourceDetailsSidebar when loading a page with lots of resources
>+        https://bugs.webkit.org/show_bug.cgi?id=159577
>+        <rdar://problem/27251461>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/ResourceDetailsSidebarPanel.js:
>+        (WI.ResourceDetailsSidebarPanel.prototype._refreshRelatedResourcesSection):
>+        (WI.ResourceDetailsSidebarPanel.prototype._applyResourceEventListeners):
>+
> 2019-02-05  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Styles: remove harmless "property was unlocked" asserts
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js
>index 047ec8043600017aea6119e33f360688375b9122..4cf9b8ac5a99189b15b9e0fedbefb37e19f24cdc 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js
>@@ -263,6 +263,8 @@ WI.ResourceDetailsSidebarPanel = class ResourceDetailsSidebarPanel extends WI.De
> 
>     _refreshRelatedResourcesSection()
>     {
>+        this._refreshRelatedResourcesSection.cancelThrottle();
>+
>         // Hide the section if we don't have anything to show.
>         let groups = this._locationSection.groups;
>         let isSectionVisible = groups.includes(this._relatedResourcesGroup);
>@@ -605,6 +607,9 @@ WI.ResourceDetailsSidebarPanel = class ResourceDetailsSidebarPanel extends WI.De
> 
>     _applyResourceEventListeners()
>     {
>+        if (!this._throttler)
>+            this._throttler = this.throttle(250);
>+
>         this._resource.addEventListener(WI.Resource.Event.URLDidChange, this._refreshURL, this);
>         this._resource.addEventListener(WI.Resource.Event.MIMETypeDidChange, this._refreshMIMEType, this);
>         this._resource.addEventListener(WI.Resource.Event.TypeDidChange, this._refreshResourceType, this);
>@@ -615,7 +620,7 @@ WI.ResourceDetailsSidebarPanel = class ResourceDetailsSidebarPanel extends WI.De
>         this._resource.addEventListener(WI.Resource.Event.MetricsDidChange, this._refreshRequestAndResponse, this);
>         this._resource.addEventListener(WI.Resource.Event.SizeDidChange, this._refreshDecodedSize, this);
>         this._resource.addEventListener(WI.Resource.Event.TransferSizeDidChange, this._refreshTransferSize, this);
>-        this._resource.addEventListener(WI.Resource.Event.InitiatedResourcesDidChange, this._refreshRelatedResourcesSection, this);
>+        this._resource.addEventListener(WI.Resource.Event.InitiatedResourcesDidChange, this._throttler._refreshRelatedResourcesSection, this);
> 
>         this._needsToRemoveResourceEventListeners = true;
>     }

Actions: View | Formatted Diff | Diff

Attachments on bug 159577: 283192 | 283583 | 284391 | 361223