Attachment 361209 Details for Bug 194282 – Patch

[patch] Patch

patch.txt (text/plain), 3.54 KB, created by Nikita Vasilyev on 2019-02-05 12:19:09 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-02-05 12:19:09 PST

Size: 3.54 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index dd06b004fc3..c827b72f976 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-02-05  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Fix modify-css-property-race.html test failures
>+        https://bugs.webkit.org/show_bug.cgi?id=194282
>+
>+        Reviewed by Matt Baker.
>+
>+        Fix test failures introduced by r240946 by providing a message for expectGreaterThan assert,
>+        so it doesn't log the actual values.
>+
>+        * inspector/css/modify-css-property-race-expected.txt:
>+        * inspector/css/modify-css-property-race.html:
>+
> 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
> 
>         [iPad] Initial test gardening (Part 1)
>diff --git a/LayoutTests/inspector/css/modify-css-property-race-expected.txt b/LayoutTests/inspector/css/modify-css-property-race-expected.txt
>index b4e857d54d5..139125488ac 100644
>--- a/LayoutTests/inspector/css/modify-css-property-race-expected.txt
>+++ b/LayoutTests/inspector/css/modify-css-property-race-expected.txt
>@@ -3,9 +3,9 @@ Testing that changes to "style" attribute made from page's JavaScript are ignore
> 
> == Running test suite: ModifyCSSProperty
> -- Running test case: ModifyCSSPropertyRace.ChangeInlineStyle
>-PASS: expectGreaterThan(43, 42)
>-PASS: expectGreaterThan(43, 42)
>-PASS: Value updated to "10px".
>+PASS: Height should be greater than 42px.
>+PASS: Height should be greater than 42px.
>+PASS: Height should be 10px.
> PASS: CSSStyleDeclaration text should update.
>-PASS: expectGreaterThanOrEqual(10, 10)
>+PASS: Height should be greater or equal 10px.
> 
>diff --git a/LayoutTests/inspector/css/modify-css-property-race.html b/LayoutTests/inspector/css/modify-css-property-race.html
>index 83c691d0183..f72b4f020ee 100644
>--- a/LayoutTests/inspector/css/modify-css-property-race.html
>+++ b/LayoutTests/inspector/css/modify-css-property-race.html
>@@ -66,17 +66,17 @@ function test() {
>             function styleDecorationUpdated(event) {
>                 if (!updateCount) {
>                     let valueNumber = parseInt(getProperty("height").rawValue);
>-                    InspectorTest.expectGreaterThan(valueNumber, 42);
>+                    InspectorTest.expectGreaterThan(valueNumber, 42, "Height should be greater than 42px.");
>                 } else if (updateCount === 1) {
>                     let valueNumber = parseInt(getProperty("height").rawValue);
>-                    InspectorTest.expectGreaterThan(valueNumber, 42);
>+                    InspectorTest.expectGreaterThan(valueNumber, 42, "Height should be greater than 42px.");
>                     getProperty("height").rawValue = "10px";
>                 } else if (updateCount === 2) {
>-                    InspectorTest.expectEqual(getProperty("height").rawValue, "10px", `Value updated to "10px".`);
>+                    InspectorTest.expectEqual(getProperty("height").rawValue, "10px", "Height should be 10px.");
>                     InspectorTest.expectEqual(getInlineStyleDeclaration().text, "height: 10px;", "CSSStyleDeclaration text should update.");
>                 } else {
>                     let valueNumber = parseInt(getProperty("height").rawValue);
>-                    InspectorTest.expectGreaterThanOrEqual(valueNumber, 10);
>+                    InspectorTest.expectGreaterThanOrEqual(valueNumber, 10, "Height should be greater or equal 10px.");
> 
>                     InspectorTest.evaluateInPage("stopExpanding()");
>                     WI.CSSStyleDeclaration.removeEventListener(WI.CSSStyleDeclaration.Event.PropertiesChanged, styleDecorationUpdated);

Actions: View | Formatted Diff | Diff

Attachments on bug 194282: 361166 | 361167 | 361168 | 361169 | 361208 | 361209