Attachment 361204 Details for Bug 194295 – Proposed patch

[patch] Proposed patch

ews-app-modified-timestamp.patch (text/plain), 2.86 KB, created by Aakash Jain on 2019-02-05 11:09:19 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-02-05 11:09:19 PST

Size: 2.86 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 240984)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-02-05  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-app] Modified timestamp should be updated on updating data
>+        https://bugs.webkit.org/show_bug.cgi?id=194295
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-app/ews/models/build.py:
>+        * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
>+        * BuildSlaveSupport/ews-app/ews/models/step.py:
>+
> 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r240742.
>Index: Tools/BuildSlaveSupport/ews-app/ews/models/build.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/models/build.py	(revision 240981)
>+++ Tools/BuildSlaveSupport/ews-app/ews/models/build.py	(working copy)
>@@ -80,7 +80,7 @@ class Build(models.Model):
>         build.state_string = state_string
>         build.started_at = started_at
>         build.complete_at = complete_at
>-        build.save(update_fields=['result', 'state_string', 'started_at', 'complete_at'])
>+        build.save(update_fields=['result', 'state_string', 'started_at', 'complete_at', 'modified'])
>         _log.info('Updated build {} in database for patch_id: {}'.format(build_id, patch_id))
>         return SUCCESS
> 
>Index: Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py	(revision 240981)
>+++ Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py	(working copy)
>@@ -67,7 +67,7 @@ class BuilderMapping(models.Model):
> 
>         mapping.builder_name = builder_name
>         mapping.display_name = display_name
>-        mapping.save(update_fields=['builder_name', 'display_name'])
>+        mapping.save(update_fields=['builder_name', 'display_name', 'modified'])
>         _log.info('Updated mapping for builder_id: {}, name: {}, display_name: {}'.format(builder_id, builder_name, display_name))
>         return SUCCESS
> 
>Index: Tools/BuildSlaveSupport/ews-app/ews/models/step.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/models/step.py	(revision 240981)
>+++ Tools/BuildSlaveSupport/ews-app/ews/models/step.py	(working copy)
>@@ -72,7 +72,7 @@ class Step(models.Model):
>         step.state_string = state_string
>         step.started_at = started_at
>         step.complete_at = complete_at
>-        step.save(update_fields=['result', 'state_string', 'started_at', 'complete_at'])
>+        step.save(update_fields=['result', 'state_string', 'started_at', 'complete_at', 'modified'])
>         _log.info('Updated step {} in database for build: {}'.format(step_id, build_id))
>         return SUCCESS
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194295: 361204