Attachment 361183 Details for Bug 194286 – Patch v1

[patch] Patch v1

bug-194286-20190205054929.patch (text/plain), 1.73 KB, created by David Kilzer (:ddkilzer) on 2019-02-05 05:49:30 PST

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2019-02-05 05:49:30 PST

Size: 1.73 KB

patch

obsolete

>Subversion Revision: 240963
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 04ec81a2f2797e80ad0e14ba3eeb357f8c850c1f..253ae8750b889d9c3a9018e5190b5a29acf0a07c 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-02-05  David Kilzer  <ddkilzer@apple.com>
>+
>+        WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
>+        <https://webkit.org/b/194286>
>+        <rdar://problem/47815558>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
>+        (WTR::InjectedBundlePage::willSendRequestForFrame): Use
>+        WKRetainPtr<> to avoid leaking the WKDataRef.
>+
> 2018-12-07  David Kilzer  <ddkilzer@apple.com>
> 
>         Ignore false-positive leaks under bmalloc::Heap::Heap
>diff --git a/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp b/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
>index f6ce4944cf927baf2b211bc83e26144ae870a632..5281d05ae4638426e9d8de0f31ad2cd0915bac5a 100644
>--- a/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
>+++ b/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
>@@ -1211,7 +1211,8 @@ WKURLRequestRef InjectedBundlePage::willSendRequestForFrame(WKBundlePageRef page
>         String body = injectedBundle.testRunner()->willSendRequestHTTPBody();
>         if (!body.isEmpty()) {
>             CString cBody = body.utf8();
>-            return WKURLRequestCopySettingHTTPBody(request, WKDataCreate(reinterpret_cast<const unsigned char*>(cBody.data()), cBody.length()));
>+            WKRetainPtr<WKDataRef> body = adoptWK(WKDataCreate(reinterpret_cast<const unsigned char*>(cBody.data()), cBody.length()));
>+            return WKURLRequestCopySettingHTTPBody(request, body.get());
>         }
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194286: 361183