WebKit Bugzilla
Attachment 361162 Details for
Bug 194280
: Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'classes.includes')
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194280-20190204231356.patch (text/plain), 1.91 KB, created by
Devin Rousso
on 2019-02-04 23:13:57 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Devin Rousso
Created:
2019-02-04 23:13:57 PST
Size:
1.91 KB
patch
obsolete
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index 630bec4dfb6c1eba5909bffb509c133e6ba5b701..ead00ac608b569227e1ad71aa0fcb4eb0c0230d6 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,15 @@ >+2019-02-04 Devin Rousso <drousso@apple.com> >+ >+ Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'classes.includes') >+ https://bugs.webkit.org/show_bug.cgi?id=194280 >+ <rdar://problem/47811159> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UserInterface/Views/GeneralStyleDetailsSidebarPanel.js: >+ (WI.GeneralStyleDetailsSidebarPanel.prototype._populateClassToggles): >+ Add a fallback value in case the `class` attribute isn't specified for the selected node. >+ > 2019-02-04 Devin Rousso <drousso@apple.com> > > Web Inspector: Resources: missing resource data for document on reload >diff --git a/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js >index c73b0b93406337e0a71622bbaa0c135961f35434..d9b165e22429f2a6abc70b475728aa4d7c577cd9 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js >+++ b/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js >@@ -359,7 +359,7 @@ WI.GeneralStyleDetailsSidebarPanel = class GeneralStyleDetailsSidebarPanel exten > while (this._classListContainer.children.length > 1) > this._classListContainer.children[1].remove(); > >- let classes = this.domNode.getAttribute("class"); >+ let classes = this.domNode.getAttribute("class") || []; > let classToggledMap = this.domNode[WI.GeneralStyleDetailsSidebarPanel.ToggledClassesSymbol]; > if (!classToggledMap) > classToggledMap = this.domNode[WI.GeneralStyleDetailsSidebarPanel.ToggledClassesSymbol] = new Map;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194280
: 361162