Attachment 361142 Details for Bug 194254 – Patch

[patch] Patch

bug-194254-20190204174732.patch (text/plain), 2.31 KB, created by Matt Baker on 2019-02-04 17:47:33 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2019-02-04 17:47:33 PST

Size: 2.31 KB

patch

obsolete

>Subversion Revision: 240951
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 3106c5b5a1916c5ebd09c6df27a9bd8fea675660..8a7937dead789443b453b9655ae85fcd074e6faf 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-02-04  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: REGRESSION (r240947): Resources tab: can't select main frame after refreshing page
>+        https://bugs.webkit.org/show_bug.cgi?id=194254
>+        <rdar://problem/47805023>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/TreeOutline.js:
>+        (WI.TreeOutline.prototype.selectionControllerSelectionDidChange):
>+        TreeOutline should always call the TreeElement `select` and `deselect`
>+        methods while processing selection changes. Having notifications
>+        suppressed by `this._suppressNextSelectionDidChangeEvent` should only
>+        affect the dispatching of TreeOutline events.
>+
> 2019-02-04  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: REGRESSION: Resources: WI.TreeOutline assertions when refreshing the page
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>index f783acdabfa6dad37ba01d535b77327775bf853e..4ef3e86eea233d28261b1381a0ff310c76bb79b0 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>@@ -812,8 +812,7 @@ WI.TreeOutline = class TreeOutline extends WI.Object
>             if (treeElement) {
>                 if (treeElement.listItemElement)
>                     treeElement.listItemElement.classList.remove("selected");
>-                if (!this._suppressNextSelectionDidChangeEvent)
>-                    treeElement.deselect();
>+                treeElement.deselect();
>             }
>         }
> 
>@@ -823,8 +822,8 @@ WI.TreeOutline = class TreeOutline extends WI.Object
>             if (treeElement) {
>                 if (treeElement.listItemElement)
>                     treeElement.listItemElement.classList.add("selected");
>-                if (!this._suppressNextSelectionDidChangeEvent)
>-                    treeElement.select();
>+                const omitFocus = true;
>+                treeElement.select(omitFocus);
>             }
>         }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194254: 361142