Attachment 361140 Details for Bug 194262 – Patch

[patch] Patch

patch.txt (text/plain), 2.63 KB, created by Nikita Vasilyev on 2019-02-04 17:33:38 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-02-04 17:33:38 PST

Size: 2.63 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 630bec4dfb6..088126e9dd7 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-02-04  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Styles: remove harmless "property was unlocked" asserts
>+        https://bugs.webkit.org/show_bug.cgi?id=194262
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/SpreadsheetStyleProperty.js:
>+        (WI.SpreadsheetStyleProperty.prototype.remove):
>+        (WI.SpreadsheetStyleProperty.prototype.update):
>+        (WI.SpreadsheetStyleProperty.prototype._handleNameChange):
>+        (WI.SpreadsheetStyleProperty.prototype._handleValueChange):
>+
> 2019-02-04  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Resources: missing resource data for document on reload
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>index b5eb8d141f6..af6c0699d00 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>@@ -131,7 +131,6 @@ WI.SpreadsheetStyleProperty = class SpreadsheetStyleProperty extends WI.Object
> 
>     remove(replacement = null)
>     {
>-        console.assert(this._property.ownerStyle.locked, `Removed property was unlocked (${this._property.name})`);
>         this.element.remove();
> 
>         if (replacement)
>@@ -156,7 +155,6 @@ WI.SpreadsheetStyleProperty = class SpreadsheetStyleProperty extends WI.Object
>             this._checkboxElement.checked = this._property.enabled;
>             this._checkboxElement.tabIndex = -1;
>             this._checkboxElement.addEventListener("click", (event) => {
>-                console.assert(this._property.ownerStyle.locked, `Toggled property was unlocked (${this._property.name})`);
>                 event.stopPropagation();
>                 let disabled = !this._checkboxElement.checked;
>                 this._property.commentOut(disabled);
>@@ -676,15 +674,11 @@ WI.SpreadsheetStyleProperty = class SpreadsheetStyleProperty extends WI.Object
> 
>     _handleNameChange()
>     {
>-        console.assert(this._property.ownerStyle.locked, `Modified property was unlocked (${this._property.name})`);
>-
>         this._property.name = this._nameElement.textContent.trim();
>     }
> 
>     _handleValueChange()
>     {
>-        console.assert(this._property.ownerStyle.locked, `Modified property was unlocked (${this._property.name})`);
>-
>         this._property.rawValue = this._valueElement.textContent.trim();
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194262: 361140