Attachment 361130 Details for Bug 194158 – Patch for landing

[patch] Patch for landing

bug-194158-20190204164848.patch (text/plain), 1.62 KB, created by Jonathan Bedard on 2019-02-04 16:48:49 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2019-02-04 16:48:49 PST

Size: 1.62 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 240944)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-02-04  Jonathan Bedard  <jbedard@apple.com>
>+
>+        webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
>+        https://bugs.webkit.org/show_bug.cgi?id=194158
>+        <rdar://problem/47737268>
>+
>+        Rubber-stamped by Aakash Jain.
>+
>+        * Scripts/webkitpy/port/device_port.py:
>+        (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
>+
> 2019-02-04  Zalan Bujtas  <zalan@apple.com>
> 
>         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
>Index: Tools/Scripts/webkitpy/port/device_port.py
>===================================================================
>--- Tools/Scripts/webkitpy/port/device_port.py	(revision 240940)
>+++ Tools/Scripts/webkitpy/port/device_port.py	(working copy)
>@@ -144,7 +144,15 @@ class DevicePort(DarwinPort):
>             if device.device_type in self.DEVICE_TYPE:
>                 types.add(device.device_type)
>         if types:
>-            return list(types)
>+
>+            def sorted_by_default_device_type(type):
>+                try:
>+                    return self.DEFAULT_DEVICE_TYPES.index(type)
>+                except ValueError:
>+                    return len(self.DEFAULT_DEVICE_TYPES)
>+
>+            return sorted(types, key=sorted_by_default_device_type)
>+
>         return self.DEFAULT_DEVICE_TYPES or [self.DEVICE_TYPE]
> 
>     def setup_test_run(self, device_type=None):

Actions: View | Formatted Diff | Diff

Attachments on bug 194158: 361110 | 361130