Attachment 361126 Details for Bug 194242 – Patch for landing

[patch] Patch for landing

bug-194242-20190204164120.patch (text/plain), 1.84 KB, created by Matt Baker on 2019-02-04 16:41:20 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2019-02-04 16:41:20 PST

Size: 1.84 KB

patch

obsolete

>Subversion Revision: 240947
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 90a3bf94ce81de7b5ed28367b69bb95921a83f55..3106c5b5a1916c5ebd09c6df27a9bd8fea675660 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-02-04  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: REGRESSION: Resources: WI.TreeOutline assertions when refreshing the page
>+        https://bugs.webkit.org/show_bug.cgi?id=194242
>+        <rdar://problem/47802027>
>+
>+        Reviewed by Joseph Pecoraro.
>+
>+        * UserInterface/Views/FolderizedTreeElement.js:
>+        (WI.FolderizedTreeElement.prototype.removeChildren):
>+        FolderTreeElements are removed by the base class call to removeChildren.
>+        Calling `removeChildren` for detached TreeElements is unnecessary.
>+
> 2019-02-04  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: REGRESSION: clicking a selected call frame doesn't re-scroll
>diff --git a/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js b/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js
>index 1edad0d82e75f01c8fdd799ecd8f9370f2dae88c..c1e546b42702c90c8bb3cc5a4bf4ea341eade389 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js
>@@ -69,17 +69,12 @@ WI.FolderizedTreeElement = class FolderizedTreeElement extends WI.GeneralTreeEle
>         this._folderizeSettingsMap.set(type, settings);
>     }
> 
>-    // Overrides from TreeElement (Private).
>-
>     removeChildren()
>     {
>         super.removeChildren();
> 
>         this._clearNewChildQueue();
> 
>-        for (var folder of this._folderTypeMap.values())
>-            folder.removeChildren();
>-
>         this._folderExpandedSettingMap.clear();
>         this._folderTypeMap.clear();
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194242: 361124 | 361126