WebKit Bugzilla
Attachment 361117 Details for
Bug 193758
: [iOS] Unable to make a selection in jsfiddle.net using arrow keys when requesting desktop site
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193758-20190204160414.patch (text/plain), 3.62 KB, created by
Wenson Hsieh
on 2019-02-04 16:04:15 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Wenson Hsieh
Created:
2019-02-04 16:04:15 PST
Size:
3.62 KB
patch
obsolete
>Subversion Revision: 240926 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index ad89714ce17a3527e1228d0ac5779ad5d80cd1bd..84d3f6ee074d377bead140c097a71fbc6562accf 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,19 @@ >+2019-02-04 Wenson Hsieh <wenson_hsieh@apple.com> >+ >+ [iOS] Unable to make a selection in jsfiddle.net using arrow keys when requesting desktop site >+ Followup to https://bugs.webkit.org/show_bug.cgi?id=193758 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Add an EditingBehavior getter on Document so that elements don't need to reach over to Frame's editor in order >+ to ask about editing behaviors. >+ >+ * dom/Document.cpp: >+ (WebCore::Document::editingBehavior const): >+ * dom/Document.h: >+ * html/HTMLInputElement.cpp: >+ (WebCore::HTMLInputElement::setDefaultSelectionAfterFocus): >+ > 2019-02-04 Wenson Hsieh <wenson_hsieh@apple.com> > > [iOS] Unable to make a selection in jsfiddle.net using arrow keys when requesting desktop site >diff --git a/Source/WebCore/dom/Document.cpp b/Source/WebCore/dom/Document.cpp >index 50bccefcde471977ce9bf431e310104a809b9e2a..d98b733559888a07b3629a8a72a612d06ae39752 100644 >--- a/Source/WebCore/dom/Document.cpp >+++ b/Source/WebCore/dom/Document.cpp >@@ -63,6 +63,7 @@ > #include "DocumentTimeline.h" > #include "DocumentType.h" > #include "Editing.h" >+#include "EditingBehavior.h" > #include "Editor.h" > #include "ElementIterator.h" > #include "EventHandler.h" >@@ -8711,4 +8712,9 @@ void Document::updateTouchActionElements(Element& element, const RenderStyle& st > } > #endif > >+EditingBehavior Document::editingBehavior() const >+{ >+ return EditingBehavior(settings().editingBehaviorType()); >+} >+ > } // namespace WebCore >diff --git a/Source/WebCore/dom/Document.h b/Source/WebCore/dom/Document.h >index 8e2878f4d15ab8515067a3aa5da3f25731102d03..6bc38a57a129279c99fa702396455087f168d727 100644 >--- a/Source/WebCore/dom/Document.h >+++ b/Source/WebCore/dom/Document.h >@@ -113,6 +113,7 @@ class DocumentParser; > class DocumentSharedObjectPool; > class DocumentTimeline; > class DocumentType; >+class EditingBehavior; > class ExtensionStyleSheets; > class FloatQuad; > class FloatRect; >@@ -1550,6 +1551,8 @@ public: > void setAlwaysAllowLocalWebarchive() { m_alwaysAllowLocalWebarchive = true; } > bool alwaysAllowLocalWebarchive() const { return m_alwaysAllowLocalWebarchive; } > >+ EditingBehavior editingBehavior() const; >+ > protected: > enum ConstructionFlags { Synthesized = 1, NonRenderedPlaceholder = 1 << 1 }; > Document(Frame*, const URL&, unsigned = DefaultDocumentClass, unsigned constructionFlags = 0); >diff --git a/Source/WebCore/html/HTMLInputElement.cpp b/Source/WebCore/html/HTMLInputElement.cpp >index cafd2dd269e313b466f0a8b878d3fa4e2c3af0f9..e5ec5c984389247930942f2c17a9f59f3d43801e 100644 >--- a/Source/WebCore/html/HTMLInputElement.cpp >+++ b/Source/WebCore/html/HTMLInputElement.cpp >@@ -38,6 +38,7 @@ > #include "ChromeClient.h" > #include "DateTimeChooser.h" > #include "Document.h" >+#include "EditingBehavior.h" > #include "Editor.h" > #include "EventNames.h" > #include "FileInputType.h" >@@ -471,8 +472,7 @@ void HTMLInputElement::setDefaultSelectionAfterFocus(SelectionRevealMode revealM > ASSERT(isTextField()); > int start = 0; > auto direction = SelectionHasNoDirection; >- auto* frame = document().frame(); >- if (frame && frame->editor().behavior().shouldMoveSelectionToEndWhenFocusingTextInput()) { >+ if (document().editingBehavior().shouldMoveSelectionToEndWhenFocusingTextInput()) { > start = std::numeric_limits<int>::max(); > direction = SelectionHasForwardDirection; > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
wenson_hsieh
:
review?
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193758
:
359995
|
360037
|
361025
|
361054
|
361112
| 361117