Attachment 361109 Details for Bug 194243 – Patch

[patch] Patch

bug-194243-20190204152921.patch (text/plain), 5.25 KB, created by Devin Rousso on 2019-02-04 15:29:22 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-02-04 15:29:22 PST

Size: 5.25 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index bcd979d271b1ae6e229fdcf4ff46e0a8533ec51b..a6828c9aba9ed63b089fc03c295fa873678f03ad 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-02-04  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Resources: missing resource data for document on reload
>+        https://bugs.webkit.org/show_bug.cgi?id=194243
>+        <rdar://problem/47559021>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/ResourceDetailsSidebarPanel.js:
>+        (WI.ResourceDetailsSidebarPanel.prototype.set resource):
>+        (WI.ResourceDetailsSidebarPanel.prototype._applyResourceEventListeners):
>+
>+        * UserInterface/Base/Object.js:
>+        (WI.Object.removeEventListener):
>+        Drive-by: there's no need to iterate over the entire table to check if `thisObject` exists,
>+        as that is handled for us by `ListMultimap`, which we later call anyways.
>+
> 2019-02-01  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: create icons for media event types instead of using a blue circle
>diff --git a/Source/WebInspectorUI/UserInterface/Base/Object.js b/Source/WebInspectorUI/UserInterface/Base/Object.js
>index e3bb5c7c952e389ff0e125061db6b4651f9cb158..4802881f7c722e28bf4d103b8d8263c04288e0bb 100644
>--- a/Source/WebInspectorUI/UserInterface/Base/Object.js
>+++ b/Source/WebInspectorUI/UserInterface/Base/Object.js
>@@ -79,12 +79,7 @@ WI.Object = class WebInspectorObject
> 
>         if (thisObject && !eventType) {
>             this._listeners.forEach(function(listenersTable) {
>-                let listenerPairs = listenersTable.toArray();
>-                for (let i = 0, length = listenerPairs.length; i < length; ++i) {
>-                    let existingThisObject = listenerPairs[i][0];
>-                    if (existingThisObject === thisObject)
>-                        listenersTable.deleteAll(existingThisObject);
>-                }
>+                listenersTable.deleteAll(thisObject);
>             });
> 
>             return;
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js
>index d6aecf47c96e59e62e14c935b0de5bb56d7495df..047ec8043600017aea6119e33f360688375b9122 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js
>@@ -82,16 +82,7 @@ WI.ResourceDetailsSidebarPanel = class ResourceDetailsSidebarPanel extends WI.De
>             return;
> 
>         if (this._resource && this._needsToRemoveResourceEventListeners) {
>-            this._resource.removeEventListener(WI.Resource.Event.URLDidChange, this._refreshURL, this);
>-            this._resource.removeEventListener(WI.Resource.Event.MIMETypeDidChange, this._refreshMIMEType, this);
>-            this._resource.removeEventListener(WI.Resource.Event.TypeDidChange, this._refreshResourceType, this);
>-            this._resource.removeEventListener(WI.Resource.Event.LoadingDidFail, this._refreshErrorReason, this);
>-            this._resource.removeEventListener(WI.Resource.Event.RequestHeadersDidChange, this._refreshRequestHeaders, this);
>-            this._resource.removeEventListener(WI.Resource.Event.ResponseReceived, this._refreshRequestAndResponse, this);
>-            this._resource.removeEventListener(WI.Resource.Event.CacheStatusDidChange, this._refreshRequestAndResponse, this);
>-            this._resource.removeEventListener(WI.Resource.Event.SizeDidChange, this._refreshDecodedSize, this);
>-            this._resource.removeEventListener(WI.Resource.Event.TransferSizeDidChange, this._refreshTransferSize, this);
>-            this._resource.removeEventListener(WI.Resource.Event.InitiatedResourcesDidChange, this._refreshRelatedResourcesSection, this);
>+            this._resource.removeEventListener(null, null, this);
> 
>             this._needsToRemoveResourceEventListeners = false;
>         }
>@@ -99,7 +90,7 @@ WI.ResourceDetailsSidebarPanel = class ResourceDetailsSidebarPanel extends WI.De
>         this._resource = resource;
> 
>         if (this._resource) {
>-            if (this.parentSidebar)
>+            if (this.didInitialLayout)
>                 this._applyResourceEventListeners();
>             else
>                 this._needsToApplyResourceEventListeners = true;
>@@ -621,6 +612,7 @@ WI.ResourceDetailsSidebarPanel = class ResourceDetailsSidebarPanel extends WI.De
>         this._resource.addEventListener(WI.Resource.Event.RequestHeadersDidChange, this._refreshRequestHeaders, this);
>         this._resource.addEventListener(WI.Resource.Event.ResponseReceived, this._refreshRequestAndResponse, this);
>         this._resource.addEventListener(WI.Resource.Event.CacheStatusDidChange, this._refreshRequestAndResponse, this);
>+        this._resource.addEventListener(WI.Resource.Event.MetricsDidChange, this._refreshRequestAndResponse, this);
>         this._resource.addEventListener(WI.Resource.Event.SizeDidChange, this._refreshDecodedSize, this);
>         this._resource.addEventListener(WI.Resource.Event.TransferSizeDidChange, this._refreshTransferSize, this);
>         this._resource.addEventListener(WI.Resource.Event.InitiatedResourcesDidChange, this._refreshRelatedResourcesSection, this);

Actions: View | Formatted Diff | Diff

Attachments on bug 194243: 361109