Attachment 361107 Details for Bug 194169 – Patch for landing

[patch] Patch for landing

bug-194169-20190204151650.patch (text/plain), 2.02 KB, created by Matt Baker on 2019-02-04 15:16:51 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2019-02-04 15:16:51 PST

Size: 2.02 KB

patch

obsolete

>Subversion Revision: 240928
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index bcd979d271b1ae6e229fdcf4ff46e0a8533ec51b..402fcd34cd4f45aff1530232c03ec1255d6115a4 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-02-04  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: REGRESSION: clicking a selected call frame doesn't re-scroll
>+        https://bugs.webkit.org/show_bug.cgi?id=194169
>+        <rdar://problem/47743864>
>+
>+        Reviewed by Devin Rousso.
>+
>+        * UserInterface/Views/TreeOutline.js:
>+        (WI.TreeOutline.prototype._handleMouseDown):
>+        Add a special case for a single-selection TreeOutline with
>+        allowsRepeatSelection enabled. Since the element is already
>+        selected, bypass the SelectionCongroller and dispatch an
>+        event with event.data.selectedByUser set to true.
>+
> 2019-02-01  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: create icons for media event types instead of using a blue circle
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>index 3f78cd5ce9baf41f9d095e2fd58ee11add5cf82b..f783acdabfa6dad37ba01d535b77327775bf853e 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>@@ -1015,6 +1015,14 @@ WI.TreeOutline = class TreeOutline extends WI.Object
>         if (!treeElement.canSelectOnMouseDown(event))
>             return;
> 
>+        if (this.allowsRepeatSelection && treeElement.selected && this._selectionController.selectedItems.size === 1) {
>+            // Special case for dispatching a selection event for an already selected
>+            // item in single-selection mode.
>+            this._itemWasSelectedByUser = true;
>+            this._dispatchSelectionDidChangeEvent();
>+            return;
>+        }
>+
>         let index = this._indexOfTreeElement(treeElement);
>         if (isNaN(index))
>             return;

Actions: View | Formatted Diff | Diff

Attachments on bug 194169: 361082 | 361107