WebKit Bugzilla
Attachment 361082 Details for
Bug 194169
: Web Inspector: REGRESSION: clicking a selected call frame doesn't re-scroll
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194169-20190204115710.patch (text/plain), 2.00 KB, created by
Matt Baker
on 2019-02-04 11:57:10 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Matt Baker
Created:
2019-02-04 11:57:10 PST
Size:
2.00 KB
patch
obsolete
>Subversion Revision: 240928 >diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index bcd979d271b1ae6e229fdcf4ff46e0a8533ec51b..5eb979fc31d530fc62881b7332de162ed4cb391b 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,18 @@ >+2019-02-04 Matt Baker <mattbaker@apple.com> >+ >+ Web Inspector: REGRESSION: clicking a selected call frame doesn't re-scroll >+ https://bugs.webkit.org/show_bug.cgi?id=194169 >+ <rdar://problem/47743864> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UserInterface/Views/TreeOutline.js: >+ (WI.TreeOutline.prototype._handleMouseDown): >+ Add a special case for a single-selection TreeOutline with >+ allowsRepeatSelection enabled. Since the element is already >+ selected, bypass the SelectionCongroller and dispatch an >+ event with event.data.selectedByUser set to true. >+ > 2019-02-01 Devin Rousso <drousso@apple.com> > > Web Inspector: create icons for media event types instead of using a blue circle >diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js >index 3f78cd5ce9baf41f9d095e2fd58ee11add5cf82b..f1d4925d8b2764d6207cf3da05fb96715fa907c5 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js >+++ b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js >@@ -1015,6 +1015,14 @@ WI.TreeOutline = class TreeOutline extends WI.Object > if (!treeElement.canSelectOnMouseDown(event)) > return; > >+ if (this.allowsRepeatSelection && !this.allowsMultipleSelection && treeElement.selected) { >+ // Special case for dispatching a selection event for an already selected >+ // item in single-selection mode. >+ this._itemWasSelectedByUser = true; >+ this._dispatchSelectionDidChangeEvent(); >+ return; >+ } >+ > let index = this._indexOfTreeElement(treeElement); > if (isNaN(index)) > return;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194169
:
361082
|
361107