WebKit Bugzilla
Attachment 361043 Details for
Bug 190895
: [curl] ASSERTION FAILED: !m_didNotifyResponse || m_multipartHandle
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-190895-20190204163428.patch (text/plain), 2.11 KB, created by
Fujii Hironori
on 2019-02-03 23:34:30 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Fujii Hironori
Created:
2019-02-03 23:34:30 PST
Size:
2.11 KB
patch
obsolete
>Subversion Revision: 240914 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index e3478e353bdf4aead441991062f9aefbedc6f60f..a4189d7fe40af69e0aa7b90f5cd62e1f905b340b 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,22 @@ >+2019-02-03 Fujii Hironori <Hironori.Fujii@sony.com> >+ >+ [curl] ASSERTION FAILED: !m_didNotifyResponse || m_multipartHandle >+ https://bugs.webkit.org/show_bug.cgi?id=190895 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ An assertion was failing in CurlRequest::invokeDidReceiveResponse >+ because DidReceiveResponse was already dispatched. This condition >+ was met if CurlRequestScheduler::completeTransfer is called while >+ waiting for the reply for the first DidReceiveResponse. >+ >+ No new tests, covered by existing tests. >+ >+ * platform/network/curl/CurlRequest.h: >+ (WebCore::CurlRequest::needToInvokeDidReceiveResponse const): >+ Return true if m_didNotifyResponse is false disregard to >+ m_didReturnFromNotify. >+ > 2019-02-03 Simon Fraser <simon.fraser@apple.com> > > Make setNeedsLayout on the root more explicitly about triggering its side-effects >diff --git a/Source/WebCore/platform/network/curl/CurlRequest.h b/Source/WebCore/platform/network/curl/CurlRequest.h >index 93ca6103fe63d5ff031055c825d80282764aedba..53aa0b55f8c0c698faeb4f1ae3dd69a1d7332413 100644 >--- a/Source/WebCore/platform/network/curl/CurlRequest.h >+++ b/Source/WebCore/platform/network/curl/CurlRequest.h >@@ -141,7 +141,7 @@ private: > void setupSendData(bool forPutMethod); > > // Processing for DidReceiveResponse >- bool needToInvokeDidReceiveResponse() const { return m_didReceiveResponse && (!m_didNotifyResponse || !m_didReturnFromNotify); } >+ bool needToInvokeDidReceiveResponse() const { return m_didReceiveResponse && !m_didNotifyResponse; } > bool needToInvokeDidCancelTransfer() const { return m_didNotifyResponse && !m_didReturnFromNotify && m_actionAfterInvoke == Action::FinishTransfer; } > void invokeDidReceiveResponseForFile(URL&); > void invokeDidReceiveResponse(const CurlResponse&, Action);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 190895
: 361043