Attachment 361039 Details for Bug 194212 – Testing...

[patch] Testing...

bug-194212-20190203225447.patch (text/plain), 1.33 KB, created by Yusuke Suzuki on 2019-02-03 22:54:48 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2019-02-03 22:54:48 PST

Size: 1.33 KB

patch

obsolete

>Subversion Revision: 240914
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index 13ca9221fd9e1e2038fe424b9f613caaf0845e31..73869594b38f4e8c32d9f31f7150b6ced24c7124 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-02-03  Yusuke Suzuki  <ysuzuki@apple.com>
>+
>+        [JSC] Make StaticStringImpl & StaticSymbolImpl actually static
>+        https://bugs.webkit.org/show_bug.cgi?id=194212
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/text/StringImpl.h:
>+        (WTF::StringImpl::ref):
>+        (WTF::StringImpl::deref):
>+
> 2019-02-03  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r240896.
>diff --git a/Source/WTF/wtf/text/StringImpl.h b/Source/WTF/wtf/text/StringImpl.h
>index bd01f2c268599dd1100ff1572c51aaad606f3d9c..e13c6d944320196da73767147c0bc269915c4de8 100644
>--- a/Source/WTF/wtf/text/StringImpl.h
>+++ b/Source/WTF/wtf/text/StringImpl.h
>@@ -1047,13 +1047,16 @@ inline void StringImpl::setHash(unsigned hash) const
> inline void StringImpl::ref()
> {
>     STRING_STATS_REF_STRING(*this);
>-
>+    if (isStatic())
>+        return;
>     m_refCount += s_refCountIncrement;
> }
> 
> inline void StringImpl::deref()
> {
>     STRING_STATS_DEREF_STRING(*this);
>+    if (isStatic())
>+        return;
> 
>     unsigned tempRefCount = m_refCount - s_refCountIncrement;
>     if (!tempRefCount) {

Actions: View | Formatted Diff | Diff

Attachments on bug 194212: 361039 | 364300