WebKit Bugzilla
Attachment 361032 Details for
Bug 194207
: [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194207-20190203161106.patch (text/plain), 2.13 KB, created by
Wenson Hsieh
on 2019-02-03 16:11:06 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Wenson Hsieh
Created:
2019-02-03 16:11:06 PST
Size:
2.13 KB
patch
obsolete
>Subversion Revision: 240902 >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index c0ae8eb2d5fa6fb49c035aacc3af4e9f28577d4a..c23d796a3fdb27af5516142f2b62ea03fec7741c 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,19 @@ >+2019-02-03 Wenson Hsieh <wenson_hsieh@apple.com> >+ >+ [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902 >+ https://bugs.webkit.org/show_bug.cgi?id=194207 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment >+ element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart >+ paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the >+ attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the >+ start and delete forwards to remove the original attachment. >+ >+ * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm: >+ (TestWebKitAPI::TEST): >+ > 2019-02-02 David Kilzer <ddkilzer@apple.com> > > Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator >diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm >index 722b68cd7a1926397b74500042536ce43658a12c..840f567d2752155cb71911eb6ca5312a5634e262 100644 >--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm >+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm >@@ -1114,7 +1114,8 @@ TEST(WKAttachmentTests, InsertAndRemoveDuplicateAttachment) > } > { > ObserveAttachmentUpdatesForScope observer(webView.get()); >- [webView _synchronouslyExecuteEditCommand:@"DeleteBackward" argument:nil]; >+ [webView evaluateJavaScript:@"getSelection().setPosition(document.body)" completionHandler:nil]; >+ [webView _synchronouslyExecuteEditCommand:@"DeleteForward" argument:nil]; > observer.expectAttachmentUpdates(@[ originalAttachment.get() ], @[ ]); > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194207
: 361032