Attachment 361012 Details for Bug 194202 – ROLLOUT of r240896

[patch] ROLLOUT of r240896

bug-194202-20190203055148.patch (text/plain), 1.71 KB, created by WebKit Commit Bot on 2019-02-03 05:51:49 PST

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Commit Bot

Created: 2019-02-03 05:51:49 PST

Size: 1.71 KB

patch

obsolete

>Subversion Revision: 240902
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index 3864715347db3a59d2b437f07614b7bc31132db3..13ca9221fd9e1e2038fe424b9f613caaf0845e31 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-02-03  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r240896.
>+        https://bugs.webkit.org/show_bug.cgi?id=194202
>+
>+        "Fixes leaks, but is probably not the correct fix." (Requested
>+        by ddkilzer on #webkit).
>+
>+        Reverted changeset:
>+
>+        "Leak of WTF::StringImpl under SymbolImpl::createNullSymbol()
>+        (48 bytes) in com.apple.WebKit.WebContent running layout
>+        tests"
>+        https://bugs.webkit.org/show_bug.cgi?id=193291
>+        https://trac.webkit.org/changeset/240896
>+
> 2019-02-02  David Kilzer  <ddkilzer@apple.com>
> 
>         Leak of WTF::StringImpl under SymbolImpl::createNullSymbol() (48 bytes) in com.apple.WebKit.WebContent running layout tests
>diff --git a/Source/WTF/wtf/text/SymbolImpl.h b/Source/WTF/wtf/text/SymbolImpl.h
>index e082e1e9c1fc5cec583250efb585bbb25faa29e4..42ff036f7fd568395fa7808bde748c4353e8e3d1 100644
>--- a/Source/WTF/wtf/text/SymbolImpl.h
>+++ b/Source/WTF/wtf/text/SymbolImpl.h
>@@ -116,13 +116,6 @@ protected:
>         ASSERT(StringImpl::tailOffset<StringImpl*>() == OBJECT_OFFSETOF(SymbolImpl, m_owner));
>     }
> 
>-    ~SymbolImpl()
>-    {
>-        if (m_owner != StringImpl::empty())
>-            m_owner->deref();
>-        m_owner = nullptr;
>-    }
>-
>     // The pointer to the owner string should be immediately following after the StringImpl layout,
>     // since we would like to align the layout of SymbolImpl to the one of BufferSubstring StringImpl.
>     StringImpl* m_owner;

Actions: View | Formatted Diff | Diff

Attachments on bug 194202: 361012