Attachment 360964 Details for Bug 194178 – Patch v2

[patch] Patch v2

bug-194178-20190201221602.patch (text/plain), 1.62 KB, created by David Kilzer (:ddkilzer) on 2019-02-01 22:16:03 PST

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2019-02-01 22:16:03 PST

Size: 1.62 KB

patch

obsolete

>Subversion Revision: 240664
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 2d0427732cdf7b1806244d5d2365cb80c3103eeb..34a6c5ac38d756d11cc53d8f5db5046f8f6a5a5a 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-02-01  David Kilzer  <ddkilzer@apple.com>
>+
>+        Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
>+        <https://webkit.org/b/194178>
>+        <rdar://problem/47753473>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
>+        (WTR::uninstallFakeHelvetica): Pass nullptr into
>+        CTFontManagerUnregisterFontsForURLs() to ignore any errors.
>+
> 2018-12-07  David Kilzer  <ddkilzer@apple.com>
> 
>         Ignore false-positive leaks under bmalloc::Heap::Heap
>diff --git a/Tools/WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm b/Tools/WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm
>index 3fef2d5818c9974d9cb9a0f734bccadc59919567..3d6adf623f7a26652c6ad4819bd1317f608bacca 100644
>--- a/Tools/WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm
>+++ b/Tools/WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm
>@@ -154,8 +154,7 @@ void uninstallFakeHelvetica()
>         if ([[url lastPathComponent] hasPrefix:@"FakeHelvetica"])
>             [fontsToRemove addObject:url];
>     }
>-    CFArrayRef errors = nullptr;
>-    CTFontManagerUnregisterFontsForURLs(static_cast<CFArrayRef>(fontsToRemove), kCTFontManagerScopeProcess, &errors);
>+    CTFontManagerUnregisterFontsForURLs(static_cast<CFArrayRef>(fontsToRemove), kCTFontManagerScopeProcess, nullptr);
> }
> 
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 194178: 360923 | 360964