Attachment 360923 Details for Bug 194178 – Patch v1

[patch] Patch v1

bug-194178-20190201162225.patch (text/plain), 1.56 KB, created by David Kilzer (:ddkilzer) on 2019-02-01 16:22:26 PST

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2019-02-01 16:22:26 PST

Size: 1.56 KB

patch

obsolete

>Subversion Revision: 240664
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 2d0427732cdf7b1806244d5d2365cb80c3103eeb..b36ed48aab133e65c94594805b5785062c21a5f9 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-02-01  David Kilzer  <ddkilzer@apple.com>
>+
>+        Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
>+        <https://webkit.org/b/194178>
>+        <rdar://problem/47753473>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
>+        (WTR::uninstallFakeHelvetica): Release `errors` if set after
>+        calling CTFontManagerUnregisterFontsForURLs().
>+
> 2018-12-07  David Kilzer  <ddkilzer@apple.com>
> 
>         Ignore false-positive leaks under bmalloc::Heap::Heap
>diff --git a/Tools/WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm b/Tools/WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm
>index 3fef2d5818c9974d9cb9a0f734bccadc59919567..c0963f0316eba602898e4d69bff2d218538dc8f8 100644
>--- a/Tools/WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm
>+++ b/Tools/WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm
>@@ -156,6 +156,11 @@ void uninstallFakeHelvetica()
>     }
>     CFArrayRef errors = nullptr;
>     CTFontManagerUnregisterFontsForURLs(static_cast<CFArrayRef>(fontsToRemove), kCTFontManagerScopeProcess, &errors);
>+    if (errors) {
>+        for (id error in (__bridge NSArray *)errors)
>+            NSLog(@"%@", (__bridge CFErrorRef)error);
>+        CFRelease(errors);
>+    }
> }
> 
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 194178: 360923 | 360964