Attachment 360889 Details for Bug 194172 – Patch

[patch] Patch

bug-194172-20190201132704.patch (text/plain), 5.69 KB, created by Jer Noble on 2019-02-01 13:27:04 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2019-02-01 13:27:04 PST

Size: 5.69 KB

patch

obsolete

>Subversion Revision: 240858
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f5995799fcff27682e84d143433aff35d4be80cc..ad5c95a806002e0da402ddc740f457a8aa3982fb 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-02-01  Jer Noble  <jer.noble@apple.com>
>+
>+        Make the WebKit default for media source based on the WebCore default.
>+        https://bugs.webkit.org/show_bug.cgi?id=194172
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * page/SettingsBase.h:
>+
> 2019-02-01  Simon Fraser  <simon.fraser@apple.com>
> 
>         REGRESSION (r240698): fast/scrolling/sticky-to-fixed.html can cause a crash
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 99a935c7d01df593613dffb36bb8bd518ede2130..14f90fccec1318e630b781d30d759459d11050a6 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-02-01  Jer Noble  <jer.noble@apple.com>
>+
>+        Make the WebKit default for media source based on the WebCore default.
>+        https://bugs.webkit.org/show_bug.cgi?id=194172
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/WebPreferences.yaml:
>+        * UIProcess/API/Cocoa/WKPreferences.mm:
>+        (-[WKPreferences _setMediaSourceEnabled:]):
>+        (-[WKPreferences _mediaSourceEnabled]):
>+        * UIProcess/API/Cocoa/WKPreferencesPrivate.h:
>+
> 2019-02-01  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         [SOUP] Improve use of SoupCookiePersistentStorageType
>diff --git a/Source/WebCore/page/SettingsBase.h b/Source/WebCore/page/SettingsBase.h
>index d370d806de574d4b156037d5fd6a4f4253fe010d..57531a1f00103141da447dd4a80fe6b2fe92d7ce 100644
>--- a/Source/WebCore/page/SettingsBase.h
>+++ b/Source/WebCore/page/SettingsBase.h
>@@ -117,7 +117,7 @@ public:
>     WEBCORE_EXPORT static bool defaultDownloadableBinaryFontsEnabled();
> 
> #if ENABLE(MEDIA_SOURCE)
>-    static bool platformDefaultMediaSourceEnabled();
>+    WEBCORE_EXPORT static bool platformDefaultMediaSourceEnabled();
> #endif
> 
>     static const unsigned defaultMaximumHTMLParserDOMTreeDepth = 512;
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index ac33c36c8ee33c89e1aea90cb17939e3fc28224c..cce4ace8356325e7a0a00e523f9e4c992f9152ff 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -574,7 +574,7 @@ SpatialNavigationEnabled:
> 
> MediaSourceEnabled:
>   type: bool
>-  defaultValue: true
>+  defaultValue: WebCore::Settings::platformDefaultMediaSourceEnabled()
>   condition: ENABLE(MEDIA_SOURCE)
> 
> ViewGestureDebuggingEnabled:
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm b/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
>index 9475df4a8b9428d86b14536d91a1bd5149244455..461c8754f94073c17788cf7ae9ce7cba97064125 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
>@@ -849,6 +849,16 @@ - (BOOL)_itpDebugModeEnabled
>     return _preferences->itpDebugModeEnabled();
> }
> 
>+- (void)_setMediaSourceEnabled:(BOOL)enabled
>+{
>+    _preferences->setMediaSourceEnabled(enabled);
>+}
>+
>+- (BOOL)_mediaSourceEnabled
>+{
>+    return _preferences->mediaSourceEnabled();
>+}
>+
> #if PLATFORM(MAC)
> - (void)_setJavaEnabledForLocalFiles:(BOOL)enabled
> {
>@@ -1053,16 +1063,6 @@ - (BOOL)_subpixelCSSOMElementMetricsEnabled
>     return _preferences->subpixelCSSOMElementMetricsEnabled();
> }
> 
>-- (void)_setMediaSourceEnabled:(BOOL)enabled
>-{
>-    _preferences->setMediaSourceEnabled(enabled);
>-}
>-
>-- (BOOL)_mediaSourceEnabled
>-{
>-    return _preferences->mediaSourceEnabled();
>-}
>-
> - (void)_setViewGestureDebuggingEnabled:(BOOL)enabled
> {
>     _preferences->setViewGestureDebuggingEnabled(enabled);
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h b/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
>index d725f32b5089ec886ca010351313136f7dccfa56..cb39fa8e04e128b9be3c6c1a703d21f2244d21a9 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
>@@ -153,6 +153,7 @@ typedef NS_ENUM(NSInteger, _WKEditableLinkBehavior) {
> @property (nonatomic, setter=_setDeviceOrientationEventEnabled:) BOOL _deviceOrientationEventEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
> @property (nonatomic, setter=_setNeedsSiteSpecificQuirks:) BOOL _needsSiteSpecificQuirks WK_API_AVAILABLE(macosx(10.13.4), ios(WK_IOS_TBA));
> @property (nonatomic, setter=_setItpDebugModeEnabled:) BOOL _itpDebugModeEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
>+@property (nonatomic, setter=_setMediaSourceEnabled:) BOOL _mediaSourceEnabled WK_API_AVAILABLE(macosx(10.13.4), ios(WK_IOS_TBA));
> 
> #if !TARGET_OS_IPHONE
> @property (nonatomic, setter=_setWebGLEnabled:) BOOL _webGLEnabled WK_API_AVAILABLE(macosx(10.13.4));
>@@ -176,7 +177,6 @@ typedef NS_ENUM(NSInteger, _WKEditableLinkBehavior) {
> @property (nonatomic, setter=_setCookieEnabled:) BOOL _cookieEnabled WK_API_AVAILABLE(macosx(10.13.4));
> @property (nonatomic, setter=_setPlugInSnapshottingEnabled:) BOOL _plugInSnapshottingEnabled WK_API_AVAILABLE(macosx(10.13.4));
> @property (nonatomic, setter=_setSubpixelCSSOMElementMetricsEnabled:) BOOL _subpixelCSSOMElementMetricsEnabled WK_API_AVAILABLE(macosx(10.13.4));
>-@property (nonatomic, setter=_setMediaSourceEnabled:) BOOL _mediaSourceEnabled WK_API_AVAILABLE(macosx(10.13.4));
> @property (nonatomic, setter=_setViewGestureDebuggingEnabled:) BOOL _viewGestureDebuggingEnabled WK_API_AVAILABLE(macosx(10.13.4));
> @property (nonatomic, setter=_setStandardFontFamily:) NSString *_standardFontFamily WK_API_AVAILABLE(macosx(10.13.4));
> @property (nonatomic, setter=_setNotificationsEnabled:) BOOL _notificationsEnabled WK_API_AVAILABLE(macosx(10.13.4));

Flags:

eric.carlson: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 194172: 360889