Attachment 360886 Details for Bug 193878 – Patch

[patch] Patch

bug-193878-20190201150808.patch (text/plain), 4.40 KB, created by Eric Liang on 2019-02-01 13:08:09 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Liang

Created: 2019-02-01 13:08:09 PST

Size: 4.40 KB

patch

obsolete

>Subversion Revision: 240863
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 70ee09c777eef10d17ffcd8dba8e032466a3ba1e..fb62197c737abf63acc0301d9d96eabaaac2d710 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-02-01  Eric Liang  <ericliang@apple.com>
>+
>+        When performing AXPress, check to see if the menu list is disabled.
>+        https://bugs.webkit.org/show_bug.cgi?id=193878
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Test: accessibility/mac/press-not-work-for-disabled-menu-list.html
>+
>+        * accessibility/AXObjectCache.h:
>+        * accessibility/AccessibilityMenuList.cpp:
>+        (WebCore::AccessibilityMenuList::press):
>+        * accessibility/mac/AXObjectCacheMac.mm:
>+        (WebCore::AXObjectCache::postPlatformNotification):
>+
> 2019-02-01  Antti Koivisto  <antti@apple.com>
> 
>         Don't use base layer() as the scroll layer in scrolling tree.
>diff --git a/Source/WebCore/accessibility/AXObjectCache.h b/Source/WebCore/accessibility/AXObjectCache.h
>index cf0a1836f8748965f6eb71f2b840b7a2124e2527..d4ba324b477b0a362825f2c39e02e049c64c84a1 100644
>--- a/Source/WebCore/accessibility/AXObjectCache.h
>+++ b/Source/WebCore/accessibility/AXObjectCache.h
>@@ -290,6 +290,8 @@ public:
>         AXRowExpanded,
>         AXExpandedChanged,
>         AXInvalidStatusChanged,
>+        AXPressDidSucceed,
>+        AXPressDidFail,
>         AXPressedStateChanged,
>         AXReadOnlyStatusChanged,
>         AXRequiredStatusChanged,
>diff --git a/Source/WebCore/accessibility/AccessibilityMenuList.cpp b/Source/WebCore/accessibility/AccessibilityMenuList.cpp
>index 6de86730e6a3e5ce0fb50f0ec1f6a0fbbb52ba9f..218545a11597b741eb6064d0ce2f7986bde7b700 100644
>--- a/Source/WebCore/accessibility/AccessibilityMenuList.cpp
>+++ b/Source/WebCore/accessibility/AccessibilityMenuList.cpp
>@@ -44,16 +44,23 @@ Ref<AccessibilityMenuList> AccessibilityMenuList::create(RenderMenuList* rendere
> 
> bool AccessibilityMenuList::press()
> {
>+    bool result = false;
> #if !PLATFORM(IOS_FAMILY)
>-    RenderMenuList* menuList = static_cast<RenderMenuList*>(renderer());
>-    if (menuList->popupIsVisible())
>-        menuList->hidePopup();
>-    else
>-        menuList->showPopup();
>-    return true;
>-#else
>-    return false;
>+    auto element = this->element();
>+    if (element && !element->isDisabledFormControl()) {
>+        RenderMenuList* menuList = downcast<RenderMenuList>(renderer());
>+        if (menuList->popupIsVisible())
>+            menuList->hidePopup();
>+        else
>+            menuList->showPopup();
>+        result = true;
>+    }
>+    AXObjectCache* cache = axObjectCache();
>+    Ref<Document> document(m_renderer->document());
>+    if (cache)
>+        cache->postNotification(element, result ? AXObjectCache::AXPressDidSucceed : AXObjectCache::AXPressDidFail);
> #endif
>+    return result;
> }
> 
> void AccessibilityMenuList::addChildren()
>diff --git a/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm b/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
>index d075550ab9393803eeb0234895d6a8c6c19fb568..f652db36e6ea679d55b47134398cbc4921471d23 100644
>--- a/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
>+++ b/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
>@@ -346,6 +346,12 @@ void AXObjectCache::postPlatformNotification(AccessibilityObject* obj, AXNotific
>         case AXMenuListItemSelected:
>             macNotification = (id)kAXMenuItemSelectedNotification;
>             break;
>+        case AXPressDidSucceed:
>+            macNotification = @"AXPressDidSucceed";
>+            break;
>+        case AXPressDidFail:
>+            macNotification = @"AXPressDidFail";
>+            break;
>         case AXMenuOpened:
>             macNotification = (id)kAXMenuOpenedNotification;
>             break;
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 8495db83da9758f0ddf774402a52ffe46bb8abe5..10b538f12035296a58f9ac02ad367ab628f4bfc9 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-02-01  Eric Liang  <ericliang@apple.com>
>+
>+        Check if receive AXPressDidFail notification when performing AXPress action on disabled MenuList.
>+        https://bugs.webkit.org/show_bug.cgi?id=193878
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * accessibility/mac/press-not-work-for-disabled-menu-list.html: Added.
>+
> 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         REGRESSION(r239915): css3/font-feature-font-face-local.html failing on WPE

Actions: View | Formatted Diff | Diff

Attachments on bug 193878: 360261 | 360266 | 360277 | 360278 | 360279 | 360284 | 360285 | 360286 | 360439 | 360886 | 360903 | 360930 | 360936 | 360939 | 360942 | 361067 | 361070