Attachment 360873 Details for Bug 194166 – Patch

[patch] Patch

bug-194166-20190201110342.patch (text/plain), 2.15 KB, created by Simon Fraser (smfr) on 2019-02-01 11:03:43 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2019-02-01 11:03:43 PST

Size: 2.15 KB

patch

obsolete

>Subversion Revision: 240826
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index a9bb66e507349bcc0088913629de1607a1dfe90f..45835981eefa4ebfd7f8bef976e0c9e7ce623258 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-02-01  Simon Fraser  <simon.fraser@apple.com>
>+
>+        Force settings.acceleratedCompositingEnabled() to true for WebKit
>+        https://bugs.webkit.org/show_bug.cgi?id=194166
>+        rdar://problem/47694328
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        WebKit relies on accelerated compositing for its drawing areas to function correctly,
>+        and sometimes clients (*cough* Safari *cough*) have bugs where they clobber the settings,
>+        so force this setting to be always on (and release log if this happens).
>+
>+        * WebProcess/WebPage/WebPage.cpp:
>+        (WebKit::WebPage::updatePreferences):
>+
> 2019-01-31  Chris Dumez  <cdumez@apple.com>
> 
>         Page zoom level is lost after a process swap or a crash
>diff --git a/Source/WebKit/WebProcess/WebPage/WebPage.cpp b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>index d9114af784b527d9cba6b15c3cf855bdc5f37894..360d4ad96e7acf4a029088bc193af2e331bd2366 100644
>--- a/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>+++ b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>@@ -3365,6 +3365,11 @@ void WebPage::updatePreferences(const WebPreferencesStore& store)
> 
>     Settings& settings = m_page->settings();
> 
>+    if (!settings.acceleratedCompositingEnabled()) {
>+        RELEASE_LOG_IF_ALLOWED("%p - WebPage - acceleratedCompositingEnabled setting was false. WebKit cannot function in this mode; changing setting to true", this);
>+        settings.setAcceleratedCompositingEnabled(true);
>+    }
>+
>     bool requiresUserGestureForMedia = store.getBoolValueForKey(WebPreferencesKey::requiresUserGestureForMediaPlaybackKey());
>     settings.setVideoPlaybackRequiresUserGesture(requiresUserGestureForMedia || store.getBoolValueForKey(WebPreferencesKey::requiresUserGestureForVideoPlaybackKey()));
>     settings.setAudioPlaybackRequiresUserGesture(requiresUserGestureForMedia || store.getBoolValueForKey(WebPreferencesKey::requiresUserGestureForAudioPlaybackKey()));

Actions: View | Formatted Diff | Diff

Attachments on bug 194166: 360873