Attachment 360863 Details for Bug 194155 – Patch

[patch] Patch

bug-194155-20190201082725.patch (text/plain), 2.06 KB, created by youenn fablet on 2019-02-01 08:27:25 PST

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-02-01 08:27:25 PST

Size: 2.06 KB

patch

obsolete

>Subversion Revision: 240633
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index fc7d52cc45c04874f2c7bf52166ad12d63be7a48..6b8e37eedf877dd29fb34d845e81fa73a21a8bb3 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-02-01  Youenn Fablet  <youenn@apple.com>
>+
>+        API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
>+        https://bugs.webkit.org/show_bug.cgi?id=194155
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
>+        Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
>+        Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
>+
> 2019-01-31  Youenn Fablet  <youenn@apple.com>
> 
>         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
>diff --git a/Tools/TestWebKitAPI/Tests/WebKit/getUserMedia.html b/Tools/TestWebKitAPI/Tests/WebKit/getUserMedia.html
>index d72ce809b1954a13e9066c717d371f156b5c7b1a..4bc074b3c508afa097561a1e52693190652b58c4 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKit/getUserMedia.html
>+++ b/Tools/TestWebKitAPI/Tests/WebKit/getUserMedia.html
>@@ -5,16 +5,15 @@
> 
>             let stream = null;
> 
>-            async function promptForCapture()
>+            function promptForCapture()
>             {
>-                try {
>-                    await navigator.mediaDevices.enumerateDevices();
>-                    const stream = await navigator.mediaDevices.getUserMedia({ audio: false, video: true })
>+                navigator.mediaDevices.enumerateDevices().then(() => {
>+                    return navigator.mediaDevices.getUserMedia({ audio: false, video: true })
>+                }).then((s) => {
>+                    stream = s;
>                     video.srcObject = stream;
>                     console.log("Got user media");
>-                } catch(error) {
>-                    console.log(`Failed with error: ${error}`);
>-                }
>+                }).catch((error) => console.log(`Failed with error: ${error}`));
>             }
> 
>             function stop(kind)

Actions: View | Formatted Diff | Diff

Attachments on bug 194155: 360863