Attachment 360860 Details for Bug 194008 – Patch

[patch] Patch

wk-control-chars.diff (text/plain), 3.54 KB, created by Carlos Garcia Campos on 2019-02-01 06:25:59 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2019-02-01 06:25:59 PST

Size: 3.54 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 0869b073c1e..01fff019ec5 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        REGRESSION(r239915): css3/font-feature-font-face-local.html failing on WPE
>+        https://bugs.webkit.org/show_bug.cgi?id=194008
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove test expectation.
>+
>+        * platform/wpe/TestExpectations:
>+
> 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed WPE gardening. Remove duplicated expectations.
>diff --git a/LayoutTests/platform/wpe/TestExpectations b/LayoutTests/platform/wpe/TestExpectations
>index 4115c361ba3..6547e574a17 100644
>--- a/LayoutTests/platform/wpe/TestExpectations
>+++ b/LayoutTests/platform/wpe/TestExpectations
>@@ -1550,8 +1550,6 @@ webkit.org/b/193517 imported/w3c/web-platform-tests/css/css-properties-values-ap
> 
> webkit.org/b/193518 imported/w3c/web-platform-tests/fetch/range/general.window.html [ Failure ]
> 
>-webkit.org/b/194008 css3/font-feature-font-face-local.html [ ImageOnlyFailure ]
>-
> webkit.org/b/194009 fast/css/has-attachment.html [ Failure ]
> 
> webkit.org/b/193629 fast/css3-text/css3-text-decoration/text-underline-style.html [ ImageOnlyFailure ]
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index fa0341fdd33..b7213993239 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        REGRESSION(r239915): css3/font-feature-font-face-local.html failing on WPE
>+        https://bugs.webkit.org/show_bug.cgi?id=194008
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We need to replace control characters with zero width space too.
>+
>+        * platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
>+        (WebCore::GlyphPage::fill):
>+        * platform/text/CharacterProperties.h:
>+        (WebCore::isControlCharacter):
>+
> 2019-02-01  Simon Fraser  <simon.fraser@apple.com>
> 
>         Use ScrollingNodeID in more places, and improve the name of a ScrollableArea function that returns a ScrollingNodeID
>diff --git a/Source/WebCore/platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp b/Source/WebCore/platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp
>index 1e85866876f..ff540d51c60 100644
>--- a/Source/WebCore/platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp
>+++ b/Source/WebCore/platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp
>@@ -71,7 +71,7 @@ bool GlyphPage::fill(UChar* buffer, unsigned bufferLength)
> 
>         Glyph glyph = FcFreeTypeCharIndex(face, FontCascade::treatAsSpace(character) ? space : character);
>         // If the font doesn't support a Default_Ignorable character, replace it with zero with space.
>-        if (!glyph && isDefaultIgnorableCodePoint(character))
>+        if (!glyph && (isDefaultIgnorableCodePoint(character) || isControlCharacter(character)))
>             glyph = zeroWidthSpaceGlyph();
> 
>         if (!glyph)
>diff --git a/Source/WebCore/platform/text/CharacterProperties.h b/Source/WebCore/platform/text/CharacterProperties.h
>index c3a10d84179..59dc1ab70b7 100644
>--- a/Source/WebCore/platform/text/CharacterProperties.h
>+++ b/Source/WebCore/platform/text/CharacterProperties.h
>@@ -111,4 +111,9 @@ inline bool isDefaultIgnorableCodePoint(UChar32 character)
>     return u_hasBinaryProperty(character, UCHAR_DEFAULT_IGNORABLE_CODE_POINT);
> }
> 
>+inline bool isControlCharacter(UChar32 character)
>+{
>+    return u_getIntPropertyValue(character, UCHAR_GENERAL_CATEGORY) == U_CONTROL_CHAR;
>+}
>+
> }

Flags:

zan: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 194008: 360860