Attachment 360856 Details for Bug 194152 – Proposed patch

[patch] Proposed patch

ews-build-unittest-builder-keys.patch (text/plain), 1.99 KB, created by Aakash Jain on 2019-02-01 03:46:31 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-02-01 03:46:31 PST

Size: 1.99 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 240841)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-02-01  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Add unit test to verify builder keys
>+        https://bugs.webkit.org/show_bug.cgi?id=194152
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
>+        (ConfigDotJSONTest.test_builder_keys): Added unit-test.
>+
> 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
>Index: Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py	(revision 240841)
>+++ Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py	(working copy)
>@@ -23,6 +23,7 @@
> # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> 
> 
>+import json
> import os
> import unittest
> 
>@@ -34,6 +35,16 @@ class ConfigDotJSONTest(unittest.TestCas
>         cwd = os.path.dirname(os.path.abspath(__file__))
>         loadConfig.loadBuilderConfig({}, master_prefix_path=cwd)
> 
>+    def test_builder_keys(self):
>+        cwd = os.path.dirname(os.path.abspath(__file__))
>+        config = json.load(open(os.path.join(cwd, 'config.json')))
>+        valid_builder_keys = ['additionalArguments', 'architectures', 'builddir', 'configuration', 'description',
>+                              'defaultProperties', 'env', 'factory', 'locks', 'name', 'platform', 'properties', 'tags',
>+                              'triggers', 'workernames', 'workerbuilddir']
>+        for builder in config.get('builders', []):
>+            for key in builder:
>+                self.assertTrue(key in valid_builder_keys, 'Unexpected key {} for builder {}'.format(key, builder.get('name')))
>+
> 
> class TagsForBuilderTeest(unittest.TestCase):
>     def verifyTags(self, builderName, expectedTags):

Actions: View | Formatted Diff | Diff

Attachments on bug 194152: 360856