WebKit Bugzilla
Attachment 360854 Details for
Bug 194150
: [WPE] Show test results in minibrowser
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
wpe-results-mb.diff (text/plain), 1.54 KB, created by
Carlos Garcia Campos
on 2019-02-01 02:42:22 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Carlos Garcia Campos
Created:
2019-02-01 02:42:22 PST
Size:
1.54 KB
patch
obsolete
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index 42af880458f..265f91945ae 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,13 @@ >+2019-02-01 Carlos Garcia Campos <cgarcia@igalia.com> >+ >+ [WPE] Show test results in minibrowser >+ https://bugs.webkit.org/show_bug.cgi?id=194150 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Scripts/webkitpy/port/wpe.py: >+ (WPEPort.show_results_html_file): >+ > 2019-02-01 Carlos Garcia Campos <cgarcia@igalia.com> > > [WPE] MiniBrowser: use g_file_new_for_commandline_arg >diff --git a/Tools/Scripts/webkitpy/port/wpe.py b/Tools/Scripts/webkitpy/port/wpe.py >index 18a9a5afc7b..050307af7fd 100644 >--- a/Tools/Scripts/webkitpy/port/wpe.py >+++ b/Tools/Scripts/webkitpy/port/wpe.py >@@ -26,6 +26,7 @@ > # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > >+from webkitpy.common.system import path > from webkitpy.common.memoized import memoized > from webkitpy.layout_tests.models.test_configuration import TestConfiguration > from webkitpy.port.base import Port >@@ -84,6 +85,9 @@ class WPEPort(Port): > self._copy_value_from_environ_if_set(environment, 'GST_DEBUG_NO_COLOR') > return environment > >+ def show_results_html_file(self, results_filename): >+ self._run_script("run-minibrowser", [path.abspath_to_uri(self.host.platform, results_filename)]) >+ > def check_sys_deps(self): > return super(WPEPort, self).check_sys_deps() and self._driver_class().check_driver(self) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
zan
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194150
: 360854