Attachment 360850 Details for Bug 194146 – Patch

[patch] Patch

wpe-mb-relative-paths.diff (text/plain), 1.41 KB, created by Carlos Garcia Campos on 2019-02-01 01:40:07 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2019-02-01 01:40:07 PST

Size: 1.41 KB

patch

obsolete

>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 8666b4c7530..42af880458f 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [WPE] MiniBrowser: use g_file_new_for_commandline_arg
>+        https://bugs.webkit.org/show_bug.cgi?id=194146
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        It allows to open relative paths.
>+
>+        * MiniBrowser/wpe/main.cpp:
>+        (main):
>+
> 2019-01-18  Philippe Normand  <pnormand@igalia.com>
> 
>         [WPE] Add API for webview background color configuration
>diff --git a/Tools/MiniBrowser/wpe/main.cpp b/Tools/MiniBrowser/wpe/main.cpp
>index 3403e609310..8070080c83b 100644
>--- a/Tools/MiniBrowser/wpe/main.cpp
>+++ b/Tools/MiniBrowser/wpe/main.cpp
>@@ -201,9 +201,13 @@ int main(int argc, char *argv[])
>     if (bgColor && webkit_color_parse(&color, bgColor))
>         webkit_web_view_set_background_color(webView, &color);
> 
>-    if (uriArguments)
>-        webkit_web_view_load_uri(webView, uriArguments[0]);
>-    else if (!automationMode)
>+    if (uriArguments) {
>+        GFile* file = g_file_new_for_commandline_arg(uriArguments[0]);
>+        char* url = g_file_get_uri(file);
>+        g_object_unref(file);
>+        webkit_web_view_load_uri(webView, url);
>+        g_free(url);
>+    } else if (!automationMode)
>         webkit_web_view_load_uri(webView, "https://wpewebkit.org");
> 
>     g_main_loop_run(loop);

Flags:

calvaris: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 194146: 360850