Attachment 360841 Details for Bug 194145 – Patch

[patch] Patch

bug-194145-20190131233405.patch (text/plain), 3.60 KB, created by Yusuke Suzuki on 2019-01-31 23:34:06 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2019-01-31 23:34:06 PST

Size: 3.60 KB

patch

obsolete

>Subversion Revision: 240836
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index db88df88d86e9fade9a9746aec4d79fb5d726f7f..31ee250dff4585c2326775c1952d4ae56598ac0f 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-01-31  Yusuke Suzuki  <ysuzuki@apple.com>
>+
>+        [JSC] Remove cellJSValueOOBSpace
>+        https://bugs.webkit.org/show_bug.cgi?id=194145
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * runtime/JSObject.h:
>+        (JSC::JSObject::subspaceFor): Deleted.
>+        * runtime/VM.cpp:
>+        (JSC::VM::VM):
>+        * runtime/VM.h:
>+
> 2019-01-31  Mark Lam  <mark.lam@apple.com>
> 
>         Remove poisoning from CodeBlock and LLInt code.
>diff --git a/Source/JavaScriptCore/runtime/JSObject.h b/Source/JavaScriptCore/runtime/JSObject.h
>index 192db5eeea713e617b71219af7f749a20ea0481f..e0caaf3002d7a07e14606a3f5efb49bdcbecd41c 100644
>--- a/Source/JavaScriptCore/runtime/JSObject.h
>+++ b/Source/JavaScriptCore/runtime/JSObject.h
>@@ -104,12 +104,6 @@ class JSObject : public JSCell {
> public:
>     typedef JSCell Base;
> 
>-    template<typename>
>-    static CompleteSubspace* subspaceFor(VM& vm)
>-    {
>-        return &vm.cellJSValueOOBSpace;
>-    }
>-
>     // This is a super dangerous method for JITs. Sometimes the JITs will want to create either a
>     // JSFinalObject or a JSArray. This is the method that will do that.
>     static JSObject* createRawObject(ExecState* exec, Structure* structure, Butterfly* = nullptr);
>diff --git a/Source/JavaScriptCore/runtime/VM.cpp b/Source/JavaScriptCore/runtime/VM.cpp
>index d91b3b85417f0d1a9df3eae4e9d8341864b20772..3b29ac1570ae9a479f6f47702916842d766fd2ee 100644
>--- a/Source/JavaScriptCore/runtime/VM.cpp
>+++ b/Source/JavaScriptCore/runtime/VM.cpp
>@@ -281,7 +281,6 @@ VM::VM(VMType vmType, HeapType heapType)
>     , primitiveGigacageAuxiliarySpace("Primitive Gigacage Auxiliary", heap, auxiliaryHeapCellType.get(), primitiveGigacageAllocator.get())
>     , jsValueGigacageAuxiliarySpace("JSValue Gigacage Auxiliary", heap, auxiliaryHeapCellType.get(), jsValueGigacageAllocator.get())
>     , immutableButterflyJSValueGigacageAuxiliarySpace("ImmutableButterfly Gigacage JSCellWithInteriorPointers", heap, immutableButterflyHeapCellType.get(), jsValueGigacageAllocator.get())
>-    , cellJSValueOOBSpace("JSCell JSValueOOB", heap, cellJSValueOOBHeapCellType.get(), fastMallocAllocator.get())
>     , cellDangerousBitsSpace("JSCell DangerousBits", heap, cellDangerousBitsHeapCellType.get(), fastMallocAllocator.get())
>     , jsValueGigacageCellSpace("JSValue Gigacage JSCell", heap, cellJSValueOOBHeapCellType.get(), jsValueGigacageAllocator.get())
>     , destructibleCellSpace("Destructible JSCell", heap, destructibleCellHeapCellType.get(), fastMallocAllocator.get())
>diff --git a/Source/JavaScriptCore/runtime/VM.h b/Source/JavaScriptCore/runtime/VM.h
>index 5839e207fe375d24d9c526090dc3bd6ba2055c93..31a13cb0f8e656dc7bccd98bccf3ec123df067b3 100644
>--- a/Source/JavaScriptCore/runtime/VM.h
>+++ b/Source/JavaScriptCore/runtime/VM.h
>@@ -359,7 +359,6 @@ class VM : public ThreadSafeRefCounted<VM>, public DoublyLinkedListNode<VM> {
>     }
>     
>     // Whenever possible, use subspaceFor<CellType>(vm) to get one of these subspaces.
>-    CompleteSubspace cellJSValueOOBSpace;
>     CompleteSubspace cellDangerousBitsSpace;
>     CompleteSubspace jsValueGigacageCellSpace; // FIXME: This space is problematic because we have things in here like DirectArguments and ScopedArguments; those should be split into JSValueOOB cells and JSValueStrict auxiliaries. https://bugs.webkit.org/show_bug.cgi?id=182858
>     CompleteSubspace destructibleCellSpace;

Flags:

mark.lam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 194145: 360841