Attachment 360834 Details for Bug 194141 – Patch

[patch] Patch

bug-194141-20190201152958.patch (text/plain), 2.29 KB, created by Fujii Hironori on 2019-01-31 22:29:59 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2019-01-31 22:29:59 PST

Size: 2.29 KB

patch

obsolete

>Subversion Revision: 240835
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 2b6b5f30167a84f539a300ed2cc9a13c10c44e9b..3494b1d5ac99f672593021250546e7749f40a424 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [curl] [WebKit] Assertion failures of missing networkStorageSession for storage/indexeddb tests
>+        https://bugs.webkit.org/show_bug.cgi?id=194141
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Implemented WebKit::NetworkProcess::switchToNewTestingSession and
>+        WebKit::NetworkProcess::ensureSession for curl port.
>+
>+        * NetworkProcess/NetworkProcess.cpp:
>+        (WebKit::NetworkProcess::switchToNewTestingSession):
>+        (WebKit::NetworkProcess::ensureSession):
>+
> 2019-01-31  Takashi Komori  <Takashi.Komori@sony.com>
> 
>         [Curl] Remove unnecessary member from NetworkStorageSession.
>diff --git a/Source/WebKit/NetworkProcess/NetworkProcess.cpp b/Source/WebKit/NetworkProcess/NetworkProcess.cpp
>index 0570953f27d75b071e8dc867c73afb39ea0e1709..1d4147286c392da48e643a351a81e90be084953b 100644
>--- a/Source/WebKit/NetworkProcess/NetworkProcess.cpp
>+++ b/Source/WebKit/NetworkProcess/NetworkProcess.cpp
>@@ -477,6 +477,8 @@ void NetworkProcess::switchToNewTestingSession()
>     m_defaultNetworkStorageSession = std::make_unique<WebCore::NetworkStorageSession>(PAL::SessionID::defaultSessionID(), WTFMove(session), WTFMove(cookieStorage));
> #elif USE(SOUP)
>     m_defaultNetworkStorageSession = std::make_unique<WebCore::NetworkStorageSession>(PAL::SessionID::defaultSessionID(), std::make_unique<WebCore::SoupNetworkSession>());
>+#elif USE(CURL)
>+    m_defaultNetworkStorageSession = std::make_unique<WebCore::NetworkStorageSession>(PAL::SessionID::defaultSessionID());
> #endif
> }
> 
>@@ -509,6 +511,8 @@ void NetworkProcess::ensureSession(const PAL::SessionID& sessionID, const String
>     addResult.iterator->value = std::make_unique<NetworkStorageSession>(sessionID, WTFMove(storageSession), WTFMove(cookieStorage));
> #elif USE(SOUP)
>     addResult.iterator->value = std::make_unique<NetworkStorageSession>(sessionID, std::make_unique<SoupNetworkSession>(sessionID));
>+#elif USE(CURL)
>+    addResult.iterator->value = std::make_unique<NetworkStorageSession>(sessionID);
> #endif
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194141: 360834