WebKit Bugzilla
Attachment 360807 Details for
Bug 194124
: Enable the automatic checking and regenerations of .xcfilelists during builds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194124-20190131165820.patch (text/plain), 6.39 KB, created by
Keith Rollin
on 2019-01-31 16:58:20 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Keith Rollin
Created:
2019-01-31 16:58:20 PST
Size:
6.39 KB
patch
obsolete
>Subversion Revision: 240827 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index c888282b4cc1b638e557d8c596cd3ba4bbc0d490..a64f2f9577f8320ffb5538f18362208d08e277ff 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,23 @@ >+2019-01-31 Keith Rollin <krollin@apple.com> >+ >+ Enable the automatic checking and regenerations of .xcfilelists during builds >+ https://bugs.webkit.org/show_bug.cgi?id=194124 >+ <rdar://problem/47721277> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Bug 193790 add a facility for checking -- during build time -- that >+ any needed .xcfilelist files are up-to-date and for updating them if >+ they are not. This facility was initially opt-in by setting >+ WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until >+ the process seemed robust. It's now time to enable this facility and >+ make it opt-out. If there is a need to disable this facility, set and >+ export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before >+ running `make` or `build-webkit`, or before running Xcode from the >+ command line, or by setting it in LocalOverrides.xcconfig. >+ >+ * Scripts/check-xcfilelists.sh: >+ > 2019-01-31 Keith Rollin <krollin@apple.com> > > Update .xcfilelist files >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index a9b6fa86d6e003a6274169f7324029b1f8160653..ff0975567affd60c40ce9dcf17c928dbe79fed1f 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,25 @@ >+2019-01-31 Keith Rollin <krollin@apple.com> >+ >+ Enable the automatic checking and regenerations of .xcfilelists during builds >+ https://bugs.webkit.org/show_bug.cgi?id=194124 >+ <rdar://problem/47721277> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Bug 193790 add a facility for checking -- during build time -- that >+ any needed .xcfilelist files are up-to-date and for updating them if >+ they are not. This facility was initially opt-in by setting >+ WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until >+ the process seemed robust. It's now time to enable this facility and >+ make it opt-out. If there is a need to disable this facility, set and >+ export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before >+ running `make` or `build-webkit`, or before running Xcode from the >+ command line, or by setting it in LocalOverrides.xcconfig. >+ >+ No new tests since there should be no observable behavior difference. >+ >+ * Scripts/check-xcfilelists.sh: >+ > 2019-01-31 Keith Rollin <krollin@apple.com> > > Update .xcfilelist files >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 807b956e6d42bac146a57f471a2904cc05f47473..26e020a3edfc5e0f6f4b23751a8e935f07ce21d2 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,23 @@ >+2019-01-31 Keith Rollin <krollin@apple.com> >+ >+ Enable the automatic checking and regenerations of .xcfilelists during builds >+ https://bugs.webkit.org/show_bug.cgi?id=194124 >+ <rdar://problem/47721277> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Bug 193790 add a facility for checking -- during build time -- that >+ any needed .xcfilelist files are up-to-date and for updating them if >+ they are not. This facility was initially opt-in by setting >+ WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until >+ the process seemed robust. It's now time to enable this facility and >+ make it opt-out. If there is a need to disable this facility, set and >+ export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before >+ running `make` or `build-webkit`, or before running Xcode from the >+ command line, or by setting it in LocalOverrides.xcconfig. >+ >+ * Scripts/check-xcfilelists.sh: >+ > 2019-01-31 Keith Rollin <krollin@apple.com> > > Update .xcfilelist files >diff --git a/Source/JavaScriptCore/Scripts/check-xcfilelists.sh b/Source/JavaScriptCore/Scripts/check-xcfilelists.sh >index 953dae273549424a79188b38b211b557d513201f..efb4ab1763d7c424ba27052c01b6eba8d8c1fb71 100755 >--- a/Source/JavaScriptCore/Scripts/check-xcfilelists.sh >+++ b/Source/JavaScriptCore/Scripts/check-xcfilelists.sh >@@ -1,6 +1,6 @@ > #!/bin/sh > >-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; } >+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; } > [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; } > [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; } > >diff --git a/Source/WebCore/Scripts/check-xcfilelists.sh b/Source/WebCore/Scripts/check-xcfilelists.sh >index c669a7de60d175e1a1c1ac3a62ab849c98db962a..585b950cdcf80a1ef12ae51748e300d34ba4b429 100755 >--- a/Source/WebCore/Scripts/check-xcfilelists.sh >+++ b/Source/WebCore/Scripts/check-xcfilelists.sh >@@ -1,6 +1,6 @@ > #!/bin/sh > >-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; } >+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; } > [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; } > [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; } > >diff --git a/Source/WebKit/Scripts/check-xcfilelists.sh b/Source/WebKit/Scripts/check-xcfilelists.sh >index 8e836f12599600eadee39dc414ea4cc4dfa85659..1150a4f60b2652d8bf28782d6b099209c2e10f08 100755 >--- a/Source/WebKit/Scripts/check-xcfilelists.sh >+++ b/Source/WebKit/Scripts/check-xcfilelists.sh >@@ -1,6 +1,6 @@ > #!/bin/sh > >-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; } >+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; } > [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; } > [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194124
:
360807
|
361098
|
361216