Attachment 360798 Details for Bug 194120 – Patch

[patch] Patch

bug-194120-20190131154024.patch (text/plain), 1.72 KB, created by Justin Fan on 2019-01-31 15:40:26 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Justin Fan

Created: 2019-01-31 15:40:26 PST

Size: 1.72 KB

patch

obsolete

>Subversion Revision: 240811
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2b94de3ac7040a85971f4fa82833f8c722562df1..7414a361a24ad022bf2db67fbb9e8f38fb101269 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-31  Justin Fan  <justin_fan@apple.com>
>+
>+        [WebGPU] Build fix: disable MTLCopyAllDevices call on non-Mac platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=194120
>+
>+        Unreviewed build fix. 
>+
>+        No new tests; no change in behavior.
>+
>+        * platform/graphics/gpu/cocoa/GPUDeviceMetal.mm:
>+        (WebCore::GPUDevice::create): Wrap problem code in #if PLATFORM(MAC).
>+
> 2019-01-31  Alex Christensen  <achristensen@webkit.org>
> 
>         Revert r238819 which is unneeded and caused a performance regression.
>diff --git a/Source/WebCore/platform/graphics/gpu/cocoa/GPUDeviceMetal.mm b/Source/WebCore/platform/graphics/gpu/cocoa/GPUDeviceMetal.mm
>index ee9777efbda0547977a165ee64c8aa3231da165f..c76ec8b1bb3b2d4c889503bab3311cac6e7d0db9 100644
>--- a/Source/WebCore/platform/graphics/gpu/cocoa/GPUDeviceMetal.mm
>+++ b/Source/WebCore/platform/graphics/gpu/cocoa/GPUDeviceMetal.mm
>@@ -42,6 +42,7 @@ RefPtr<GPUDevice> GPUDevice::create(Optional<GPURequestAdapterOptions>&& options
> 
>     BEGIN_BLOCK_OBJC_EXCEPTIONS;
>     
>+#if PLATFORM(MAC)
>     if (options && options->powerPreference == GPURequestAdapterOptions::PowerPreference::LowPower) {
>         auto devices = adoptNS(MTLCopyAllDevices());
>         
>@@ -54,6 +55,7 @@ RefPtr<GPUDevice> GPUDevice::create(Optional<GPURequestAdapterOptions>&& options
>     }
>     
>     if (!devicePtr)
>+#endif // PLATFORM(MAC)
>         devicePtr = adoptNS(MTLCreateSystemDefaultDevice());
> 
>     END_BLOCK_OBJC_EXCEPTIONS;

Actions: View | Formatted Diff | Diff

Attachments on bug 194120: 360797 | 360798