WebKit Bugzilla
Attachment 360788 Details for
Bug 194116
: [WHLSL] Expressions can't be copyable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194116-20190131144324.patch (text/plain), 2.47 KB, created by
Myles C. Maxfield
on 2019-01-31 14:43:25 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Myles C. Maxfield
Created:
2019-01-31 14:43:25 PST
Size:
2.47 KB
patch
obsolete
>Subversion Revision: 240821 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 3849c9970edd9c8b4847ba6f2de3c3cf634351a6..594cabdbe21b60544b96de0404a83c6d42e512ae 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,17 @@ >+2019-01-31 Myles C. Maxfield <mmaxfield@apple.com> >+ >+ [WHLSL] Expressions can't be copyable >+ https://bugs.webkit.org/show_bug.cgi?id=194116 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Expressions have UniqueRef members, which can't be copied. Describe this constraint explicitly rather than implicitly. >+ >+ No new tests because there is no behavior change. >+ >+ * Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h: >+ * Modules/webgpu/WHLSL/AST/WHLSLExpression.h: >+ > 2019-01-31 Keith Rollin <krollin@apple.com> > > WebCore::WHLSL::AST::Expression copy constructor needs to be be default, not delete >diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h >index ee745e54bd0542f37bb3d9814374eb3e60fca591..e41995d0809494941cd4c120398382e203f236df 100644 >--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h >+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h >@@ -50,7 +50,7 @@ public: > > virtual ~EnumerationMemberLiteral() = default; > >- explicit EnumerationMemberLiteral(const EnumerationMemberLiteral&) = default; >+ explicit EnumerationMemberLiteral(const EnumerationMemberLiteral&) = delete; > EnumerationMemberLiteral(EnumerationMemberLiteral&&) = default; > > EnumerationMemberLiteral& operator=(const EnumerationMemberLiteral&) = delete; >diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.h >index 4edbb75143e511f008cf5e600971e3b96be83634..b7ab20ced2c453f95f1c2e3efc281fda48e5c3ad 100644 >--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.h >+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.h >@@ -49,10 +49,10 @@ public: > > virtual ~Expression() = default; > >- Expression(const Expression&) = default; >+ Expression(const Expression&) = delete; > Expression(Expression&&) = default; > >- Expression& operator=(const Expression&) = default; >+ Expression& operator=(const Expression&) = delete; > Expression& operator=(Expression&&) = default; > > const Lexer::Token& origin() const { return m_origin; }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
ews-watchlist
:
commit-queue-
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194116
: 360788 |
360810